WordPress.org

Make WordPress Core

Opened 19 months ago

Last modified 9 days ago

#48896 new defect (bug)

When enqueued wp-color-picker, toggle response of each widget panel is unresponsive on customizer.

Reported by: inc2734 Owned by:
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Customize Keywords: needs-patch needs-testing
Focuses: Cc:

Description

Confirmed to occur on Android Chrome.
It was not reproduced on iOS Safari, Mac Chrome / Safari.
Perhaps opening and closing will ignite at the same time.

Reproduction code

/themes/widget-test
├ style.css
├ functions.php
└ index.php

style.css

/**
 * Theme name: widget test
 */

functions.php

<?php
add_action(
	'widgets_init',
	function() {
		register_sidebar(
			[
				'name'          => __( 'sidebar', 'widget-test' ),
				'id'            => 'widget-test-sidebar',
				'before_widget' => '<div id="%1$s" class="c-widget %2$s">',
				'after_widget'  => '</div>',
				'before_title'  => '<h2 class="c-widget__title">',
				'after_title'   => '</h2>',
			]
		);
	}
);

add_action(
	'admin_enqueue_scripts',
	function() {
		wp_enqueue_script( 'wp-color-picker' );
	}
);

index.php

<head>
	<?php wp_head(); ?>
</head>
<body>
	<?php dynamic_sidebar( 'widget-test-sidebar' ); ?>
	<?php wp_footer(); ?>
</body>

Attachments (2)

48896.mov (331.2 KB) - added by dlh 19 months ago.
A widget acting though it was clicked twice.
android-chrome.mp4 (343.8 KB) - added by inc2734 19 months ago.
I tapped at regular intervals. At that time, DOM is shining.

Download all attachments as: .zip

Change History (9)

#1 @kmix39
19 months ago

Reproduced :
-Android Firefox

Did not reproduce :
-iOS Firefox

#2 @dlh
19 months ago

  • Keywords reporter-feedback added
  • Version 5.3 deleted

Hi @inc2734, and thanks for this report and the detailed replication steps.

Are you able to provide a screen capture of this behavior?

Also, can you confirm whether the same bug occurs with widgets on the standalone /wp-admin/widgets.php page?

I don't have an Android device to test with, but I do see some strange behavior when using the replication code in the Firefox device emulator. A "touch" action is treated like a double-click: An open widget collapses then expands again, or vice versa.

@dlh
19 months ago

A widget acting though it was clicked twice.

#3 @inc2734
19 months ago

Are you able to provide a screen capture of this behavior?

I will prepare it later.

Also, can you confirm whether the same bug occurs with widgets on the standalone /wp-admin/widgets.php page?

/wp-admin/widgets.php works correctly.

@inc2734
19 months ago

I tapped at regular intervals. At that time, DOM is shining.

#4 @dlh
18 months ago

  • Keywords needs-patch added; reporter-feedback removed
  • Milestone changed from Awaiting Review to Future Release

Thanks for the screen capture, @inc2734!

From what I can see in the video, the widget form does expand or collapse some of the time, but not every time it was tapped. Is that correct?

I've been unable to replicate the issue so far in the browser emulator, and, as I said, I don't have an Android device available. So, it seems as though this issue needs a patch, but it would be helpful for whoever picks up this ticket to try to describe the cause in a device-independent way, if that's even possible.

#5 @celloexpressions
2 weeks ago

  • Keywords needs-testing added
  • Milestone changed from Future Release to 5.8

This is likely fixed/invalidated by the block based widget editor in 5.8. Milestoning for testing/confirmation.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


2 weeks ago

#7 @desrosj
9 days ago

  • Milestone changed from 5.8 to 5.9

While the traditional widget screen is being replaced with a block based widget editor, the Classic Widgets plugin will be maintained for a bit of time in the same way the Classic Editor was (expect an announcement to set expectations soon).

With that in mind, enhancement and feature requests will most likely no longer be considered. But bug tickets are still welcome, so long as they don't require too many resources distracting away from block based editing.

Since the 5.8 deadline is today and this ticket still requires testing to confirm it is reliably reproducible before patching, I'm going to punt this one. I'll move to 5.9 with the hopes we can resolve this sooner rather than later so that Classic Widget users can see this fixed.

Note: See TracTickets for help on using tickets.