WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 4 weeks ago

#49030 new defect (bug)

Twenty Twenty: video resize functionality also impacts other elements on the page

Reported by: jeherve Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:
PR Number:

Description

Twenty Twenty bundles a functionality named "Intrinsic Ratio Embeds", allowing videos (iframe, object, video) to be automatically resized on demand.

This is practical, but can be problematic for some elements on the page that may not behave like a video, or that may not be in the post content at all.

While plugins can use the .intrinsic-ignore CSS class to avoid being impacted by this, I wonder if we could be a bit more specific within the theme, and only target videos inside the post content. This would avoid conflicting with plugins adding iFrames and / or videos outside of the post content, like in widgets.

Attachments (1)

49030.diff (609 bytes) - added by jeherve 2 months ago.
Only target videos inside post content

Download all attachments as: .zip

Change History (3)

@jeherve
2 months ago

Only target videos inside post content

#1 @lancewillett
7 weeks ago

+1 for limiting the scope of this JavaScript script to only look for objects in post content.

#2 @arcio
4 weeks ago

Please fix this, not all iframes are videos.

Note: See TracTickets for help on using tickets.