WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#49214 closed defect (bug) (fixed)

Typo "siteurl" in network.php

Reported by: tobifjellner Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3.2
Component: Networks and Sites Keywords: good-first-bug has-patch
Focuses: multisite Cc:

Description

Hi
In wp-admin/includes/network.php around line 271 there's a string that writes word "siteurl" as one word where is should probably be split into two. The full string is:

We recommend you change your siteurl to %1$s before enabling the network feature. It will still be possible to visit your site using the %3$s prefix with an address like %2$s but any links will not have the %3$s prefix.

Reported by: @ramiy

Attachments (1)

fix-siteurl-string.49214.diff (912 bytes) - added by kharisblank 3 months ago.
Fix siteurl string

Download all attachments as: .zip

Change History (4)

@kharisblank
3 months ago

Fix siteurl string

#1 @tobifjellner
3 months ago

  • Keywords has-patch added; needs-patch removed

#2 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Thanks for the ticket and the patch!

For some context, this message is displayed when the site domain includes www. It refers to the siteurl option, labeled as "WordPress Address (URL)" in General Settings.

Changing this to "site URL" or "site domain" (since it refers to the domain, not the full URL) seems fine at a glance.

#3 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47085:

Networks and Sites: Clarify the recommendation to remove the www prefix from the site domain before creating a network.

The siteurl option reference was not quite clear, and the string actually refers to the domain name, not the full URL.

Props kharisblank, tobifjellner, ramiy.
Fixes #49214.

Note: See TracTickets for help on using tickets.