Opened 5 years ago
Closed 4 years ago
#49246 closed defect (bug) (fixed)
Page, Post and Comments admin screens: issue on small screens
Reported by: | passoniate | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | has-screenshots has-patch commit |
Focuses: | ui, accessibility, css | Cc: |
Description
when trash a comment, page or post then number of items overlap to button
Attachments (9)
Change History (25)
This ticket was mentioned in Slack in #accessibility by afercia. View the logs.
5 years ago
#4
@
5 years ago
- Keywords needs-design-feedback added
- Milestone changed from Awaiting Review to Future Release
This ticket was discussed during today's accessibility bug-scrub: overlapping text is an accessibility issue but agreed this would need some design feedback to start with and the CSS team to explore solutions :)
#5
@
4 years ago
We've made a design that could possible work. We moved the num of items to the top and hid the bottom one. I've also attached a .diff file with the changes that need to be made.
Also props to:
@uxkai
@ireneyoast
@thijsvanloef
Made on the Yoast contributor day.
This ticket was mentioned in Slack in #design by karmatosed. View the logs.
4 years ago
This ticket was mentioned in Slack in #design by karmatosed. View the logs.
4 years ago
This ticket was mentioned in Slack in #accessibility by afercia. View the logs.
4 years ago
#11
@
4 years ago
- Keywords needs-design-feedback removed
Capturing notes from today's Accessibility scrub:
Removing needs-design-feedback
per @afercia:
If we don't change the placement, I don't think it needs design feedback.
If placement is changed, please re-add the keyword.
Per @audrasjb:
I can test the patch later today
#12
@
4 years ago
- Keywords commit added; needs-testing removed
I tested the proposed patch and it looks good to me (see above screenshots).
Marking this for commit
.
This ticket was mentioned in Slack in #accessibility by audrasjb. View the logs.
4 years ago
#14
@
4 years ago
I don't really love the idea of taking up more vertical real estate but short of tackling the whole subnav header holistically this is probably as good as we'll get for now.
#15
@
4 years ago
Having extensively tested the patch on various screens, with and without multiple pages, took a slightly different approach.
49246.3.diff maintains the current position of the items count (below the table), and only wraps it to a new line when necessary. Also brings some consistency to bottom paddings across various screens (Posts, Tags, Comments, Users), while we're at it.
Screenshots, with and without pagination: 49246.3.png.
Note: this happens also on WordPress 5.2 and previous versions. As far as I can tell, the number of items has always been positioned absolutely, which is the root cause of the issue.