WordPress.org

Make WordPress Core

Opened 22 months ago

Closed 22 months ago

#49302 closed defect (bug) (fixed)

Theme action button container is out of align by 1px

Reported by: ideaboxcreations Owned by: audrasjb
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3
Component: Themes Keywords: good-first-bug has-screenshots has-patch commit
Focuses: ui, css, administration Cc:

Description

Theme action button container is 1px larger than its parent container. It can be fixed by reducing padding.

Steps to check:

  1. Go to WP admin > Appearance > Themes
  2. Check the action button container

I've attached a screenshot for reference.

Attachments (5)

Screenshot 2020-01-27 at 4.16.06 PM.png​ (31.0 KB) - added by ideaboxcreations 22 months ago.
See the highlighted area.
Screenshot 2020-01-27 at 4.17.28 PM.png​ (51.0 KB) - added by ideaboxcreations 22 months ago.
Zoomed a little bit in case if not visible
49302.diff​ (123.9 KB) - added by aftabmuni 22 months ago.
Reduced padding of button container by 1px.
49302_1.diff​ (737 bytes) - added by aftabmuni 22 months ago.
Removed changes from minified files.
49302.2.diff​ (681 bytes) - added by alexischenal 22 months ago.
New refreshed patch

Download all attachments as: .zip

Change History (15)

@ideaboxcreations
22 months ago

See the highlighted area.

@ideaboxcreations
22 months ago

Zoomed a little bit in case if not visible

#1 @audrasjb
22 months ago

  • Milestone changed from Awaiting Review to 5.4
  • Owner set to audrasjb
  • Status changed from new to accepted
  • Version changed from trunk to 5.3

Welcome to WordPress Trac @ideaboxcreations and thank you for opening this ticket,

I can reproduce the issue on both Chrome and Firefox / Mac OS.
Moving to milestone 5.4.

#2 @audrasjb
22 months ago

  • Keywords has-screenshots added

This could be fixed either by using a transparent background on .theme-actions div element, or different padding values.

Last edited 22 months ago by audrasjb (previous) (diff)

#3 @Presskopp
22 months ago

  • Keywords good-first-bug added

@aftabmuni
22 months ago

Reduced padding of button container by 1px.

#4 @aftabmuni
22 months ago

  • Keywords has-patch added; needs-patch removed

#5 @Presskopp
22 months ago

You don't need to patch the minified versions...

@aftabmuni
22 months ago

Removed changes from minified files.

#6 follow-up: @audrasjb
22 months ago

  • Keywords needs-refresh added

Thanks for your contribution @aftabmuni !
RTL files are also automatically generated. I'll test your proposal and make sure to refresh the patch from trunk in the next few hours. This ticket is still on track for beta 1.

#7 in reply to: ↑ 6 @aftabmuni
22 months ago

Oh So Sorry.

Replying to audrasjb:

Thanks for your contribution @aftabmuni !
RTL files are also automatically generated. I'll test your proposal and make sure to refresh the patch from trunk in the next few hours. This ticket is still on track for beta 1.

#8 @audrasjb
22 months ago

No worries @aftabmuni It's nearly alright, just need few checks and refresh before commit ;-)

@alexischenal
22 months ago

New refreshed patch

#9 @audrasjb
22 months ago

  • Keywords commit added; needs-refresh removed

Thanks @alexischenal I tested the latest patch and it looks good to go on my side, marking this for commit.

Last edited 22 months ago by audrasjb (previous) (diff)

#10 @SergeyBiryukov
22 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 47293:

Themes: Correct the height of theme actions button container on various screen sizes.

Props aftabmuni, alexischenal, ideaboxcreations, audrasjb, SergeyBiryukov.
Fixes #49302.

Note: See TracTickets for help on using tickets.