WordPress.org

Make WordPress Core

Opened 7 months ago

Last modified 4 weeks ago

#49558 accepted enhancement

Remove noreferrer from wp_targeted_link_rel and other uses

Reported by: joostdevalk Owned by: SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: General Keywords: has-unit-tests has-patch
Focuses: Cc:

Description (last modified by SergeyBiryukov)

When we added noopener noreferrer in #37941, the noreferrer bit was added specifically because at the time, Firefox didn't support noopener. Since it does now and has for a while, see here, I think we should remove it, as it does have nasty side effects: it breaks cross-site analytics.

We should remove it everywhere, as links in the admin don't send a referrer anyway after [41741] and as such there's no security risk to removing it.

Attachments (1)

49558.diff (31.4 KB) - added by audrasjb 4 weeks ago.
General: Remove noreferrer value from wp_targeted_link_rel and other uses

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
7 months ago

  • Milestone changed from Awaiting Review to 5.5
  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#3 @peterwilsoncc
7 months ago

  • Keywords needs-patch needs-unit-tests late added

Yes, I very much think this of benefit to the WP and its users.

However, the WP browser support policy still includes Edge 18 as it has over 1% usage at the time of writing.

Let's keep an eye on the Can I Use browser usage stats and gleefully commit this once the EdgeHTML Edge browser use drops below the WP support levels.

My hunch is that it will still make the 5.5 milestone, so I am keeping milestone unchanged.

#4 follow-up: @SergeyBiryukov
3 months ago

  • Description modified (diff)
  • Milestone changed from 5.5 to 5.6

It looks like Edge 18 still has 1.49% usage, so this cannot be addressed in time for 5.5, moving to 5.6.

#5 in reply to: ↑ 4 @elgameel
3 months ago

Replying to SergeyBiryukov:

It looks like Edge 18 still has 1.49% usage, so this cannot be addressed in time for 5.5, moving to 5.6.

I've been waiting for removing the tag and I think it should be fixed asap, not delaying it!

It is causing problems with affiliate tracking and making WordPress users lose earnings.

And in order to remove it, we need to switch each block with a link to HTML view and manually remove the tag.

@audrasjb
4 weeks ago

General: Remove noreferrer value from wp_targeted_link_rel and other uses

#6 @audrasjb
4 weeks ago

  • Keywords has-unit-tests has-patch added; needs-patch needs-unit-tests late removed

Given Edge is less than 1% market share now (0.77% - September 1, 2020), let's get rid of this attribute value.

Note: See TracTickets for help on using tickets.