Make WordPress Core

Opened 6 years ago

Last modified 5 weeks ago

#49731 new defect (bug)

Display embeds in WordPress plugin descriptions

Reported by: dd32's profile dd32 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Plugins Keywords: has-patch has-test-info
Focuses: administration Cc:

Description (last modified by dd32)

The WordPress.org plugin directory supports two shortcode embeds (specifically [youtube and [vimeo) and several oembed locations.

Most of these embeds appear to return iframe elements, which are removed by Core, see $plugins_allowedtags.

For example, the Updraft Plus plugin has an embed on the WordPress.org site, but not within the WordPress Add new plugin screen.
If you have Jetpack installed, it appears that it converts the iframe into a shortcode and displays that instead.

This was originally reported as #meta2846, see that ticket for an example of the HTML that's stripped by this behaviour.

Attachments (1)

plugin-description-popup.png (492.7 KB) - added by nikunj8866 7 weeks ago.

Download all attachments as: .zip

Change History (8)

#1 @dd32
6 years ago

  • Description modified (diff)

#2 @dd32
6 years ago

  • Description modified (diff)

This ticket was mentioned in PR #10321 on WordPress/wordpress-develop by @nikunj8866.


7 weeks ago
#3

  • Keywords has-patch added

#4 @nikunj8866
7 weeks ago

  • Keywords needs-test-info needs-testing added

This ticket was mentioned in Slack in #core-test by nikunj8866. View the logs.


5 weeks ago

#6 @khushdoms
5 weeks ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/10321.diff

Environment

  • WordPress: 6.9-beta2-61080-src
  • PHP: 8.2.29
  • Server: nginx/1.29.0
  • Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.29)
  • Browser: Chrome 141.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Twenty-Five 1.3
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

Additional Notes

  • https://prnt.sc/gG86pUDea5k5

Supplemental Artifacts

#7 @nikunj8866
5 weeks ago

  • Keywords has-test-info added; needs-test-info needs-testing removed
Note: See TracTickets for help on using tickets.