Make WordPress Core

Opened 3 years ago

Closed 16 months ago

Last modified 14 months ago

#49760 closed enhancement (fixed)

Twenty Fifteen: Add gradient background options that fit the theme color scheme

Reported by: ianbelanger's profile ianbelanger Owned by: audrasjb's profile audrasjb
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: good-first-bug has-patch commit needs-user-docs
Focuses: ui Cc:

Description

Now that we have the option for certain blocks to have gradient backgrounds, we need to add gradient background options to the theme that fit the themes color scheme.

Attachments (2)

2015_before.png (134.6 KB) - added by pls78 16 months ago.
Gradient background colors before applying PR
2015_after.png (129.8 KB) - added by pls78 16 months ago.
Gradient background colors after applying PR

Download all attachments as: .zip

Change History (17)

This ticket was mentioned in PR #365 on WordPress/wordpress-develop by itsamoreh.


3 years ago
#1

  • Keywords has-patch added; needs-patch removed

Add theme support and css classes for gradient background options in the twentyfifteen theme.

I used the theme colors for "from" and lightened or darkened by 10% to get the "to" colors.

Trac ticket: https://core.trac.wordpress.org/ticket/49760

Here's a screenshot of the gradients on the buttons:
![ 2020-06-26 at 17 32 37 ](https://user-images.githubusercontent.com/12365909/85903388-33e7cb00-b7d4-11ea-99e8-e48944035d3f.png)

#2 @itsamoreh
3 years ago

  • Keywords needs-patch added; has-patch removed

I submitted a PR for this. I tried to match the theme's color scheme.

This is my first ticket so let me know if I did something wrong!

#3 @itsamoreh
3 years ago

  • Keywords has-patch added; needs-patch removed

#4 @pls78
16 months ago

Hi! I tested the PR and it adds gradient background options that fit the theme colour scheme.

This is the background color select before applying the PR:
https://core.trac.wordpress.org/attachment/ticket/49760/2015_before.png

This is the background color select after applying the PR:
https://core.trac.wordpress.org/attachment/ticket/49760/2015_after.png

However, I'm experiencing the same behaviour reported in this comment: https://core.trac.wordpress.org/ticket/49761#comment:4 related to twenty fourteen theme.

Last edited 16 months ago by pls78 (previous) (diff)

@pls78
16 months ago

Gradient background colors before applying PR

@pls78
16 months ago

Gradient background colors after applying PR

#5 @audrasjb
16 months ago

  • Milestone changed from Future Release to 6.0

Moving for 6.0 consideration

#6 @audrasjb
16 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

Self assigning for review

#8 @audrasjb
16 months ago

  • Keywords commit added

The patch looks good to me. I put it together in a PR to run unit tests but it looks good to go, thank for testing :)

#9 @audrasjb
16 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 52722:

Twenty Fifteen: Add gradient background options using the theme color scheme.

This change implements gradient background options that fit the color scheme used in Twenty Fifteen.

Props ianbelanger, itsamoreh, pls78, audrasjb.
Fixes #49760.

#10 @audrasjb
16 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening this ticket because the above commit was reverted, since it was accidentally committed to branch 5.9 instead of trunk…

#11 @audrasjb
16 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 52724:

Twenty Fifteen: Add gradient background options using the theme color scheme.

This change implements gradient background options that fit the color scheme used in Twenty Fifteen.

Props ianbelanger, itsamoreh, pls78, audrasjb.
Fixes #49760.

#14 @milana_cap
15 months ago

  • Keywords needs-codex added

#15 @dd32
14 months ago

  • Keywords needs-user-docs added; needs-codex removed
Note: See TracTickets for help on using tickets.