Make WordPress Core

Opened 4 years ago

Closed 4 weeks ago

#49765 closed enhancement (wontfix)

Twenty Ten: Add gradient background options that fit the theme color scheme

Reported by: ianbelanger's profile ianbelanger Owned by: williampatton's profile williampatton
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch close
Focuses: ui Cc:

Description

Now that we have the option for certain blocks to have gradient backgrounds, we need to add gradient background options to the theme that fit the themes color scheme.

Attachments (2)

49765.patch (3.1 KB) - added by tomjdevisser 3 years ago.
Added gradient backgrounds in the style of the theme.
Schermafbeelding 2021-05-10 om 21.25.50.png (74.1 KB) - added by tomjdevisser 3 years ago.
Example of the added gradients

Download all attachments as: .zip

Change History (12)

@tomjdevisser
3 years ago

Added gradient backgrounds in the style of the theme.

#1 @tomjdevisser
3 years ago

As the theme doesn't have many colors, I added pretty general gradients using shades of white, grey and black, as well as WordPress' blue colors.

#2 @tomjdevisser
3 years ago

  • Keywords has-patch added; needs-patch good-first-bug removed

@tomjdevisser
3 years ago

Example of the added gradients

This ticket was mentioned in Slack in #core-themes by tomjdevisser. View the logs.


3 years ago

#4 @williampatton
3 years ago

  • Owner set to williampatton
  • Status changed from new to assigned

#5 follow-up: @williampatton
3 years ago

Hey @tomjdevisser,

Thanks for making this patch! I have scanned the code and it looks good to me, I will test it later today and make sure it runs fine on a test site.

#6 in reply to: ↑ 5 @tomjdevisser
3 years ago

Replying to williampatton:

Hey @tomjdevisser,

Thanks for making this patch! I have scanned the code and it looks good to me, I will test it later today and make sure it runs fine on a test site.

Thanks!

#7 @karmatosed
5 weeks ago

Looking at this now, I would like us to consider if adding this is the right path - it absolutely might be. Whilst yes, there is gradient functionality in the editor it tends to come through theme.json and default options there. This theme doesn't support that currently, so adding to the code for me seems perhaps the wrong approach.

Perhaps a better approach could be to think of how theme.json and the editor, specifically in this case the button block can have better defaults for gradients that all themes benefit from? This takes it outside a solution just for this theme. However, it doesn't make it uniquely styled.

I wonder what others think on this? I am absolutely happy to consider the patch if others also still have appetite for this.

This ticket was mentioned in Slack in #core-themes by karmatosed. View the logs.


5 weeks ago

#9 @karmatosed
4 weeks ago

  • Keywords close added

There was discussion on this within Slack and agreement reached to mark this to close for now along with any other ticket implementing gradients like this. Thank you everyone for collaboration.

#10 @karmatosed
4 weeks ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

I am going to close this as it was discussed in Slack, along with other tickets around gradients. I am closing them all together after having left them open for a few days with the close keyword for feedback. Thank you everyone for your collaboration.

Note: See TracTickets for help on using tickets.