Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#49896 closed defect (bug) (fixed)

Twenty Twenty: Button styles produce inconsistent output and cannot be edited

Reported by: nrqsnchz's profile nrqsnchz Owned by: ianbelanger's profile ianbelanger
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:


Running Gutenberg Version 7.9.0-rc.1
Running Twenty Twenty Version: 1.2

When using the 'Buttons' block, I noticed that the button styles for 'Default' and 'Outline' produce the same output on both the editor and the front-end. I'm also noticing that the style preview looks the same for both.

Also important to note that any changes to the text and background colors on both button styles produce no effect.

Attachments (1)

49896.patch (919 bytes) - added by kjellr 3 years ago.

Download all attachments as: .zip

Change History (9)

#1 @poena
3 years ago

I see a visible white outline, both in your picture and in the theme, almost as if the colors were reverted; of course, the outline style is not meant to be filled in.

#2 @nrqsnchz
3 years ago

  • Summary changed from Twenty Twenty: Both button styles produce same output to Twenty Twenty: Button styles produce inconsistent output and cannot be edited

I see a visible white outline

Thank you @poena. I'll update the ticket.

3 years ago

#4 @kjellr
3 years ago

49896.patch should get the outline/filled styles working when the plugin is active, while also retaining support for older versions (It does not fix the custom colors).

Last edited 3 years ago by kjellr (previous) (diff)

#5 @ianbelanger
3 years ago

  • Focuses css added
  • Keywords has-patch added; needs-patch removed
  • Owner set to ianbelanger
  • Status changed from new to reviewing

Thanks @kjellr, I'll test it and get it committed.

There also appears to be an issue in the Gutenberg plugin with backwards compatibility in the button block. I have reported it upstream

Getting the back compat issue fixed will hopefully fix the color option issues.

#6 @ianbelanger
3 years ago

  • Milestone changed from Awaiting Review to 5.5

#7 @ianbelanger
3 years ago

  • Keywords commit added; needs-testing removed

Patch looks for good for the button style issue, so I am marking for commit. Hopefully the color issue will be fixed upstream.

#8 @ianbelanger
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47614:

Bundled Themes: Twenty Twenty button styles produce inconsistent output and cannot be edited.

Fixes the issue with button styles not working when the Gutenberg plugin is activated while maintaining backwards compatibility.

Props nrqsnchz, poena, kjellr.
Fixes #49896.

Note: See TracTickets for help on using tickets.