WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 2 months ago

#49913 closed task (blessed) (fixed)

New Dashicons

Reported by: EmpireOfLight Owned by: desrosj
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch has-dev-note
Focuses: ui Cc:

Description (last modified by SergeyBiryukov)

This will be the final update to dashicons.

Future efforts will be focused on the new Icon component, see https://make.wordpress.org/design/2020/04/20/next-steps-for-dashicons/ for more details.

Attachments (15)

big_patch.diff (189.4 KB) - added by EmpireOfLight 5 months ago.
dashicons.css (60.9 KB) - added by EmpireOfLight 5 months ago.
dashicons.min.css (59.0 KB) - added by EmpireOfLight 5 months ago.
dashicons.woff (25.5 KB) - added by EmpireOfLight 5 months ago.
dashicons.woff2 (25.5 KB) - added by EmpireOfLight 5 months ago.
dashicons.ttf (55.1 KB) - added by EmpireOfLight 5 months ago.
big_patch.2.diff (189.4 KB) - added by EmpireOfLight 5 months ago.
dashicons.2.svg (121.7 KB) - added by EmpireOfLight 5 months ago.
dashicons.2.css (60.9 KB) - added by EmpireOfLight 5 months ago.
This css file has all the new icons
dashicons.min.2.css (57.7 KB) - added by EmpireOfLight 5 months ago.
This css file has all the new icons
49913.diff (322.4 KB) - added by desrosj 2 months ago.
dashicons.2.woff2 (25.5 KB) - added by desrosj 2 months ago.
dashicons.2.ttf (55.1 KB) - added by desrosj 2 months ago.
dashicons.3.svg (121.7 KB) - added by desrosj 2 months ago.
dashicons.eot (55.2 KB) - added by desrosj 2 months ago.

Download all attachments as: .zip

Change History (35)

This ticket was mentioned in Slack in #design-dashicons by empireoflight. View the logs.


5 months ago

#2 @EmpireOfLight
5 months ago

Please use big_patch.2.diff and ignore big_patch.diff (couldn't figure out how to delete it)

#3 @Joen
5 months ago

Thank you Ben. This is a big improvement to the Dashicons sprite, and it adds a ton of new icons. There's more context in https://make.wordpress.org/design/2020/04/20/next-steps-for-dashicons/.

@EmpireOfLight
5 months ago

This css file has all the new icons

@EmpireOfLight
5 months ago

This css file has all the new icons

This ticket was mentioned in Slack in #design-dashicons by empireoflight. View the logs.


5 months ago

#5 @Joen
4 months ago

Just wanted to note that as of https://github.com/WordPress/dashicons/pull/419, we'll want to update this patch again.

We should get these icons in WordPress 5.5, and although this is a bit out, it would be nice to merge early so we can discover any issues that might occur. Thank you to reviewers.

#6 @SergeyBiryukov
4 months ago

  • Description modified (diff)

#7 @SergeyBiryukov
4 months ago

  • Description modified (diff)

#8 @SergeyBiryukov
4 months ago

#50270 was marked as a duplicate.

@desrosj
2 months ago

@desrosj
2 months ago

@desrosj
2 months ago

@desrosj
2 months ago

#9 follow-up: @desrosj
2 months ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 5.5
  • Owner changed from empireoflight to desrosj
  • Type changed from enhancement to task (blessed)
  • Version trunk deleted

This ticket seems to have fallen through the cracks for 5.5. I fortunately stumbled upon this fact looking through some Meta tickets the other day.

I am moving to 5.5 and reclassifying as a task, but I'm requesting the approval of @SergeyBiryukov as the Core Tech Lead to include this change in 5.5 post Beta 1.

This update to Dashicons would mark the final release of the Dashicons font per the proposed roadmap on Make Core. Releasing this version in Core allows the Dashicons repository to be archived and closed, directing all new requests to the new Icon component.

Though technically an enhancement, this is actually just an update to a CSS file, and four isolated font or sprite files.

This ticket was mentioned in Slack in #design-dashicons by desrosj. View the logs.


2 months ago

#11 in reply to: ↑ 9 @SergeyBiryukov
2 months ago

Replying to desrosj:

I am moving to 5.5 and reclassifying as a task, but I'm requesting the approval of @SergeyBiryukov as the Core Tech Lead to include this change in 5.5 post Beta 1.

Sure, sounds good to me. This appears to be originally planned for 5.5 and accidentally missed. Thanks for catching that!

#12 @desrosj
2 months ago

  • Keywords commit needs-dev-note added

#13 @desrosj
2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 48456:

Administration: Update Dashicons to the latest version.

This update introduces the following new icons:

  • .dashicons-align-pull-left (f10a)
  • .dashicons-align-pull-right (f10b)
  • .dashicons-block-default (f12b)
  • .dashicons-cloud-saved (f137)
  • .dashicons-cloud-upload (f13b)
  • .dashicons-columns (f13c)
  • .dashicons-cover-image (f13d)
  • .dashicons-embed-audio (f13e)
  • .dashicons-embed-generic (f13f)
  • .dashicons-embed-photo (f144)
  • .dashicons-embed-post (f146)
  • .dashicons-embed-video (f149)
  • .dashicons-exit (f14a)
  • .dashicons-html (f14b)
  • .dashicons-info-outline (f14c)
  • .dashicons-insert-after (f14d)
  • .dashicons-insert-before (f14e)
  • .dashicons-remove (f14f)
  • .dashicons-shortcode (f150)
  • .dashicons-table-col-after (f151)
  • .dashicons-table-col-before (f152)
  • .dashicons-table-col-delete (f15a)
  • .dashicons-table-row-after (f15b)
  • .dashicons-table-row-before (f15c)
  • .dashicons-table-row-delete (f15d)
  • .dashicons-saved (f15e)
  • .dashicons-airplane (f15f)
  • .dashicons-amazon (f162)
  • .dashicons-bank (f16a)
  • .dashicons-beer (f16c)
  • .dashicons-bell (f16d)
  • .dashicons-calculator (f16e)
  • .dashicons-coffee (f16f)
  • .dashicons-database-add (f170)
  • .dashicons-database-export (f17a)
  • .dashicons-database-import (f17b)
  • .dashicons-database-remove (f17c)
  • .dashicons-database-view (f17d)
  • .dashicons-database (f17e)
  • .dashicons-drumstick (f17f)
  • .dashicons-edit-page (f186)
  • .dashicons-food (f187)
  • .dashicons-fullscreen-alt (f188)
  • .dashicons-fullscreen-exit-alt (f189)
  • .dashicons-games (f18a)
  • .dashicons-google (f18b)
  • .dashicons-hourglass (f18c)
  • .dashicons-linkedin (f18d)
  • .dashicons-money-alt (f18e)
  • .dashicons-open-folder (f18f)
  • .dashicons-pdf (f190)
  • .dashicons-pets (f191)
  • .dashicons-pinterest (f192)
  • .dashicons-printer (f193)
  • .dashicons-privacy (f194)
  • .dashicons-reddit (f195)
  • .dashicons-spotify (f196)
  • .dashicons-superhero-alt (f197)
  • .dashicons-superhero (f198)
  • .dashicons-twitch (f199)
  • .dashicons-whatsapp (f19a)
  • .dashicons-youtube (f19b)
  • .dashicons-car (f16b)
  • .dashicons-podio (f19c)
  • .dashicons-xing (f19d)

This update is the final planned update of the Dashicons font. Moving forward, the more modern approach of using SVG icons directly (as the block editor currently does) will be explored. More information on the future of Dashicons can be found on the Make Design blog: https://make.wordpress.org/design/2020/04/20/next-steps-for-dashicons/.

Props joen, johnjamesjacoby, empireoflight, youknowriad, netweb, zodiac1978, desrosj, automaton, chrisvanpatten.
Fixes #49913.

#14 @afercia
2 months ago

Coincidentally, I was looking for some new dashicons :)

Is updating the related page for developers already planned? Or should I just try all the new dashicons manually, for now? /Cc @desrosj

#15 @desrosj
2 months ago

  • Keywords commit removed

@afercia Updating the developer resource for Dashicons is being tracked in Meta-5172.

Expect a dev note to be published this week detailing all of the included changes (including new icons). The developer resource is usually not updated until the new release is publicly available to prevent potential confusion.

#16 @afercia
2 months ago

Thanks @desrosj! f16c

This ticket was mentioned in Slack in #design-dashicons by empireoflight. View the logs.


2 months ago

#18 @desrosj
2 months ago

  • Keywords has-dev-note added; needs-dev-note removed

#19 @desrosj
2 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to address a minor issue in the new database icons. As spotted by @johnbillion, the database export and database import icons have the arrows pointing in the wrong directions. The arrow should be pointing in for import and out for export.

A PR has been opened here: https://github.com/WordPress/dashicons/pull/420

#20 @desrosj
2 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 48506:

Administration: Reverse the arrow direction for database import/export icons.

In [48456], database import and export icons were introduced. However, the arrows were pointing in the wrong directions. This reverses the arrows to be pointing correctly based on the action described in the name.

Props johnbillion, joen, desrosj, empireoflight.
Fixes #49913.

Note: See TracTickets for help on using tickets.