Opened 5 years ago
Closed 4 years ago
#49913 closed task (blessed) (fixed)
New Dashicons
Reported by: | EmpireOfLight | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | has-patch has-dev-note |
Focuses: | ui | Cc: |
Description (last modified by )
This will be the final update to dashicons.
Future efforts will be focused on the new Icon component, see https://make.wordpress.org/design/2020/04/20/next-steps-for-dashicons/ for more details.
Attachments (15)
Change History (35)
This ticket was mentioned in Slack in #design-dashicons by empireoflight. View the logs.
5 years ago
#3
@
5 years ago
Thank you Ben. This is a big improvement to the Dashicons sprite, and it adds a ton of new icons. There's more context in https://make.wordpress.org/design/2020/04/20/next-steps-for-dashicons/.
This ticket was mentioned in Slack in #design-dashicons by empireoflight. View the logs.
5 years ago
#5
@
4 years ago
Just wanted to note that as of https://github.com/WordPress/dashicons/pull/419, we'll want to update this patch again.
We should get these icons in WordPress 5.5, and although this is a bit out, it would be nice to merge early so we can discover any issues that might occur. Thank you to reviewers.
#9
follow-up:
↓ 11
@
4 years ago
- Keywords has-patch added; needs-patch removed
- Milestone changed from Awaiting Review to 5.5
- Owner changed from empireoflight to desrosj
- Type changed from enhancement to task (blessed)
- Version trunk deleted
This ticket seems to have fallen through the cracks for 5.5. I fortunately stumbled upon this fact looking through some Meta tickets the other day.
I am moving to 5.5 and reclassifying as a task, but I'm requesting the approval of @SergeyBiryukov as the Core Tech Lead to include this change in 5.5 post Beta 1.
This update to Dashicons would mark the final release of the Dashicons font per the proposed roadmap on Make Core. Releasing this version in Core allows the Dashicons repository to be archived and closed, directing all new requests to the new Icon component.
Though technically an enhancement, this is actually just an update to a CSS file, and four isolated font or sprite files.
This ticket was mentioned in Slack in #design-dashicons by desrosj. View the logs.
4 years ago
#11
in reply to:
↑ 9
@
4 years ago
Replying to desrosj:
I am moving to 5.5 and reclassifying as a task, but I'm requesting the approval of @SergeyBiryukov as the Core Tech Lead to include this change in 5.5 post Beta 1.
Sure, sounds good to me. This appears to be originally planned for 5.5 and accidentally missed. Thanks for catching that!
#14
@
4 years ago
Coincidentally, I was looking for some new dashicons :)
Is updating the related page for developers already planned? Or should I just try all the new dashicons manually, for now? /Cc @desrosj
#15
@
4 years ago
- Keywords commit removed
@afercia Updating the developer resource for Dashicons is being tracked in Meta-5172.
Expect a dev note to be published this week detailing all of the included changes (including new icons). The developer resource is usually not updated until the new release is publicly available to prevent potential confusion.
This ticket was mentioned in Slack in #design-dashicons by empireoflight. View the logs.
4 years ago
#18
@
4 years ago
- Keywords has-dev-note added; needs-dev-note removed
Dev note published: https://make.wordpress.org/core/2020/07/15/dashicons-in-wordpress-5-5-the-final-update/. Thanks everyone!
#19
@
4 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening to address a minor issue in the new database icons. As spotted by @johnbillion, the database export and database import icons have the arrows pointing in the wrong directions. The arrow should be pointing in for import and out for export.
A PR has been opened here: https://github.com/WordPress/dashicons/pull/420
Please use big_patch.2.diff and ignore big_patch.diff (couldn't figure out how to delete it)