Improve paginator in general-template.php

[lolitsjohnnyboy]

I would like to add custom classes to the default paginator in the general-template.php file. For that I would suggest the following change:

<?php
$page_links[] = sprintf(
        '<a class="page-numbers %s" href="%s">%s</a>',
        /** This filter is documented in wp-includes/general-template.php */
        esc_attr( apply_filters( 'paginate_classes' ) ),
        esc_url( apply_filters( 'paginate_links', $link ) ),
        $args['before_page_number'] . number_format_i18n( $n ) . $args['after_page_number']
);

That needs to be applied to every page-numbers element and would be very helpful.

[sabernhardt]

#35696 suggests adding classes to multiple elements in the same hook.

[SirLouen]

@lolitsjohnnyboy looks good, but we need more info, explain how it will be used. This could be technically applied to a dozen of classes and its not a common practice in the WP code to filter classes (after all we have other classes to target if needed). According to @sabernhardt related ticket #35696 there seems to be an alternative option that could fit better.

So I will leave this to be evaluated, ideally both tickets at the same time and leave just one for a conclusion.