#50109 closed enhancement (fixed)
Twenty Twenty: Customize: retina_logo should be hidden when no logo is set
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.5 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Bundled Theme | Keywords: | has-patch commit |
| Focuses: | Cc: |
Description
In the TwentyTwenty theme, the Customize setting Site Identity > Retina logo should be hidden if there is no logo is set in Site Identity > Logo.
Attachments (2)
Change History (7)
#1
@
4 years ago
- Summary changed from Customize: retina_logo should be hidden when no logo is set to Twenty Twenty: Customize: retina_logo should be hidden when no logo is set
#2
@
4 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 5.5
- Owner set to ianbelanger
- Status changed from new to reviewing
- Version trunk deleted
Patch looks good @truongwp. I only uploaded my patch as yours would not apply for me. I used the same exact code as yours and it works perfectly. I'll be committing this soon. Thanks for your contribution!!
#4
@
4 years ago
@ianbelanger Can we change doc block?
Shows or hides the "retina_logo" setting based on the given value.
replace to
Show or hide the "retina_logo" setting based on the given value.
#5
@
4 years ago
I think we should use third-person verbs: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/#documenting-tips
Note: See
TracTickets for help on using
tickets.
Updated patch because previous patch would not apply for me