WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#50109 closed enhancement (fixed)

Twenty Twenty: Customize: retina_logo should be hidden when no logo is set

Reported by: truongwp Owned by: ianbelanger
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

In the TwentyTwenty theme, the Customize setting Site Identity > Retina logo should be hidden if there is no logo is set in Site Identity > Logo.

Attachments (2)

50109.diff (2.5 KB) - added by truongwp 6 months ago.
50109.1.diff (1.2 KB) - added by ianbelanger 6 months ago.
Updated patch because previous patch would not apply for me

Download all attachments as: .zip

Change History (7)

@truongwp
6 months ago

#1 @SergeyBiryukov
6 months ago

  • Summary changed from Customize: retina_logo should be hidden when no logo is set to Twenty Twenty: Customize: retina_logo should be hidden when no logo is set

@ianbelanger
6 months ago

Updated patch because previous patch would not apply for me

#2 @ianbelanger
6 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.5
  • Owner set to ianbelanger
  • Status changed from new to reviewing
  • Version trunk deleted

Patch looks good @truongwp. I only uploaded my patch as yours would not apply for me. I used the same exact code as yours and it works perfectly. I'll be committing this soon. Thanks for your contribution!!

#3 @ianbelanger
6 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47776:

Bundled Themes: Twenty Twenty customizer retina_logo should be hidden when no logo is set.

Modifies the Customize setting Site Identity > Retina logo so that the option is hidden if there is no logo is set in Site Identity > Logo.

Props truongwp.
Fixes #50109.

#4 @mukesh27
6 months ago

@ianbelanger Can we change doc block?

Shows or hides the "retina_logo" setting based on the given value.

replace to

Show or hide the "retina_logo" setting based on the given value.

Note: See TracTickets for help on using tickets.