WordPress.org

Make WordPress Core

Opened 5 months ago

Last modified 2 months ago

#50169 reopened enhancement

Consistency in Gallery and Image block settings

Reported by: antpb Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 5.4.1
Component: Media Keywords: needs-design needs-patch needs-screenshots
Focuses: Cc:

Description (last modified by afercia)

In the Gutenberg repo we have been tracking an issue focused on unifying the Gallery and Image editing experience. Currently, it's a bit disconnected from image settings and this ticket aims to change the Gallery block to create instances of image blocks rather than raw markup

https://github.com/WordPress/gutenberg/issues/11436

From the issue:

Is your feature request related to a problem? Please describe.
Single and gallery options should be similar to each other.
I added one image to a gallery and want to resize it in a similar way to how I resize single images. Not possible. I want to add images by clicking the standard add image media library screen but it only says upload an image. It should be identical to the single image media selection options.

Describe the solution you'd like
I would like to see much more consistency between single image and gallery options. It should be very easy to go from one to the other with similar options. As one begins working with images an expectation is created that image options should be similar between various blocks that handle images.

Single image options

http://user-images.githubusercontent.com/5323259/47937002-c17bf600-dedf-11e8-9823-ad596ce22764.png

Gallery image options

https://user-images.githubusercontent.com/5323259/47937047-dfe1f180-dedf-11e8-8b08-0db18edc2eb2.png

Single image upload media options:

https://user-images.githubusercontent.com/5323259/47937075-ee300d80-dedf-11e8-8bb1-44a47574e2ac.png

Gallery upload media options:

https://user-images.githubusercontent.com/5323259/47937095-fbe59300-dedf-11e8-88d9-6dbea7190f78.png

Captions are also different from single images to the gallery.
Top example shows the Gallery and bottom a single image.

https://user-images.githubusercontent.com/5323259/47940629-8e3f6400-deeb-11e8-9ff6-cfa71c5daccf.png

Btw
It would also be very helpful to be able to rearrange the gallery images by using drag and drop.

Attachments (1)

cross origin.png (244.6 KB) - added by afercia 5 months ago.

Download all attachments as: .zip

Change History (11)

#1 @afercia
5 months ago

  • Description modified (diff)
  • Keywords needs-screenshots added

I don't think images from GitHub can be embedded into a Trac ticket, because of cross-origin restrictions. The images in the ticket description aren't visible. See screenshot attached below. When you have a chance, would you mind re-embedding the images from another source (and with http, not https) or upload them to the ticket as attachments?

On the other hand, I'm not sure why this ticket is on Trac. Shouldn't this issue be addressed in Gutenberg, on the linked issue https://github.com/WordPress/gutenberg/issues/11436 ?

@afercia
5 months ago

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


3 months ago

#3 @sageshilling
3 months ago

working to bring consistency to the front and back end data flow to the future media for the block editor.
First introducing three elements; media library, uploader, image tray
media library component based located as pop out menu
uploader component based functions similar as it does now
image tray holds reusable image blocks located in the inserter
https://docs.google.com/document/d/1HsW-AgJryaB4_wMFIkX7PE2Q-TKI5Pfsfsjpp-Ru1Qk/edit?usp=sharing

This ticket was mentioned in Slack in #design by sageshilling. View the logs.


3 months ago

#5 @afercia
3 months ago

Maybe it's a language thing as I'm not a native English speaker but I'm not sure I fully understand the previous comment.

Comments on tickets, especially when they aim to explain technical details / implementation, should be very clear and not force others to read an attached Google doc.

Reading the attached Google doc, I'm not sure I fully understand the nature, details, and opportunity of the proposal. Not sure I understand why the backbonejs-powered media library should be abandoned in the first place, as it's very unlikely any React-based alternative implementation would be able to have feature parity.

Also, this is arguably out of the scope of this issue which is focused on "Consistency in Gallery and Image block settings". A discussion on an eventual React replacement should happen on a specific ticket and preferably in a broader context e.g. Core dev chat and/or a post on the Make blog.

#6 @mapk
3 months ago

  • Resolution set to invalid
  • Status changed from new to closed

Shouldn't this issue be addressed in Gutenberg, on the linked issue https://github.com/WordPress/gutenberg/issues/11436 ?

I agree with @afercia here. This ticket seems to be addressing the settings of the Image and Gallery blocks which are being discussed in the GitHub issue. Let's close this one in favor of that issue.

Once the Gallery block uses nested Image blocks, much of this should be resolved.

#7 @mapk
3 months ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

I'm reopening this ticket after a discussion with @sageshilling. @sageshilling please fill in the details why. Thanks!

#8 @davidbaumwald
3 months ago

  • Milestone changed from 5.5 to Future Release

With 5.5 Beta 1 releasing tomorrow, this is being moved to Future Release. If any maintainer or committer feels the remainder of this ticket can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

This ticket was mentioned in Slack in #design by sageshilling. View the logs.


3 months ago

#10 @curtiskessler
2 months ago

In accordance with this proposition, I specifically suggest enabling custom links for images found in a gallery block.

Currently, an image block image can have custom links to any URL, but gallery block images can only link to the attachment page or media file.

Note: See TracTickets for help on using tickets.