Make WordPress Core

Opened 4 years ago

Last modified 3 weeks ago

#50182 new defect (bug)

Majority of bundled themes have broken mobile nav menus when JS turned off

Reported by: westonruter's profile westonruter Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-patch
Focuses: ui, accessibility Cc:

Description

I tried turning off JavaScript in my browser (via DevTools in Chrome) and then activated each core theme to see if I could access mobile nav menu items. Unfortunately, for the themes which have an expandable mobile nav menu, the majority fail to gracefully degrade when JavaScript is disabled (either on purpose or the script fails to load over the network).

Themes which gracefully degrade by just revealing all the nav menu items:

  • Twenty Nineteen
  • Twenty Seventeen
  • Twenty Sixteen

Themes which show a mobile nav menu button which does nothing when tapped:

  • Twenty Twenty (mobile search also broken)
  • Twenty Fifteen
  • Twenty Fourteen (mobile search also broken)
  • Twenty Thirteen
  • Twenty Twelve

Attachments (1)

50182.diff (8.3 KB) - added by dboy1988 4 years ago.

Download all attachments as: .zip

Change History (7)

#1 follow-up: @afercia
4 years ago

I guess Twenty Eleven and Twenty Ten aren't mentioned to show some mercy? :)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 years ago

#3 @afercia
4 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

This ticket was discussed during today's accessibility bug-scrub. As a general consideration, the accessibility team agrees the navigation menu implementation in Twenty Seventeen it the bet one so far. Twenty Seventeen got a lot of work on the menu and that is the pattern the team recommends.

A quick win could be to _not_ hide the mobile menu when JS is off. Something to consider for the Themes team :) Moving to Future Release for now.

#4 in reply to: ↑ 1 @westonruter
4 years ago

Replying to afercia:

I guess Twenty Eleven and Twenty Ten aren't mentioned to show some mercy? :)

No, it's because they don't have a mobile menu button. And Twenty Ten isn't responsive at all.

@dboy1988
4 years ago

#5 @dboy1988
4 years ago

Patch provided

#6 @poena
3 weeks ago

Could we combine this with https://core.trac.wordpress.org/ticket/44537?
Or perhaps better, replace them with one new ticket about fixing any and all menu issues when JavaScript is disabled?
CC @karmatosed

Note: See TracTickets for help on using tickets.