#50182 closed defect (bug) (maybelater)
Majority of bundled themes have broken mobile nav menus when JS turned off
| Reported by: | westonruter | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Focuses: | ui, accessibility |
Description
I tried turning off JavaScript in my browser (via DevTools in Chrome) and then activated each core theme to see if I could access mobile nav menu items. Unfortunately, for the themes which have an expandable mobile nav menu, the majority fail to gracefully degrade when JavaScript is disabled (either on purpose or the script fails to load over the network).
Themes which gracefully degrade by just revealing all the nav menu items:
- Twenty Nineteen
- Twenty Seventeen
- Twenty Sixteen
Themes which show a mobile nav menu button which does nothing when tapped:
- Twenty Twenty (mobile search also broken)
- Twenty Fifteen
- Twenty Fourteen (mobile search also broken)
- Twenty Thirteen
- Twenty Twelve
Attachments (1)
Change History (17)
This ticket was mentioned in Slack in #accessibility by afercia. View the logs.
6 years ago
#3
@
6 years ago
- Keywords needs-patch added
- Milestone Awaiting Review → Future Release
This ticket was discussed during today's accessibility bug-scrub. As a general consideration, the accessibility team agrees the navigation menu implementation in Twenty Seventeen it the bet one so far. Twenty Seventeen got a lot of work on the menu and that is the pattern the team recommends.
A quick win could be to _not_ hide the mobile menu when JS is off. Something to consider for the Themes team :) Moving to Future Release for now.
#4
in reply to: ↑ 1
@
6 years ago
Replying to afercia:
I guess Twenty Eleven and Twenty Ten aren't mentioned to show some mercy? :)
No, it's because they don't have a mobile menu button. And Twenty Ten isn't responsive at all.
#6
@
3 years ago
Could we combine this with https://core.trac.wordpress.org/ticket/44537?
Or perhaps better, replace them with one new ticket about fixing any and all menu issues when JavaScript is disabled?
CC @karmatosed
#7
@
2 years ago
@poena unless I am mistaken this ticket could become the one for all menu issues, so let's close #44537 to combine.
#9
@
2 years ago
Related: I was on a slow connection and I loaded the WCEU site but the JavaScript was taking a long time to load. I could see the nav menu button but when I tapped it nothing would happen. Even tapping it 50 times yielded no results (😜). Ideally we wouldn't need JavaScript to open the menu in the first place, which I think is now a real possibility thanks to the Popover API which can be entirely declarative.
#10
@
2 years ago
I gave the Popover API a try, but it seems we'll have to wait for "invoker commands" to land in the web platform for this to be a viable declarative replacement for the Interactivity API: https://github.com/WordPress/gutenberg/pull/63917
This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.
19 months ago
#12
@
8 weeks ago
- Keywords 2nd-opinion added
How is everyone feeling about this ticket now? It's been quite a few years, things have changed. I am going to pose a few questions to see about a resolution here:
- Do people feel due to time it's no longer the best option to offer any patch?
- Do people feel that there is a better path forward with things that have changed in technology?
Personally, I would opt to close this gently at this point, but that doesn't mean a dismissal if someone wants to champion this with a patch which can also close this.
#13
@
8 weeks ago
@karmatosed I'm fine with closing maybelayer. I think priority should be given to the Navigation block so that going forward block themes will work with JS turned off (or if the JS for nav fails to load).
#14
@
8 weeks ago
- Milestone Future Release
- Resolution → maybelater
- Status new → closed
Thank you for your feedback @westonruter - I would second that. Right now focusing where we can on tickets around tools and features over individual themes is a more robust path.
#15
@
8 weeks ago
- Keywords needs-patch 2nd-opinion removed
I agree about not investing much effort to show the navigation menus on small (or zoomed) screens for several individual themes.
However, the search and menu toggle buttons can still appear when they have no function. I'll open tickets for hiding the unusable buttons in Twenty Twenty and Twenty Fifteen (because those two themes already have .hide-no-js and/or .no-js classes).
Now opened: #66174 and #66175
I guess Twenty Eleven and Twenty Ten aren't mentioned to show some mercy? :)