Add i18n to size_format

[Rahe]

Hello,

The units of the size_format function aren't translatable.
They are already translated on the network settings pages for the size of the upload folder or the size of the uploadable files.

Nicolas,

Change the size_format and wp_convert_bytes_to_hr to add translatable strings for the units

Trac ticket: https://core.trac.wordpress.org/ticket/50194

[audrasjb]

Hey,

This change makes sense to me.
I’d just suggest to add an additional translator comment when the file size is null, as the translation may be different for some locales in this specific case.

Maybe something like /* translators: File size in bytes, when the file size is null. */ ?

[audrasjb]

Let's move this ticket to milestone 5.5.

[Rahe]

Pull request updated

Thank you for the review, everything is modified according to the comments

[Rahe]

PR updated :)

[Rahe]

Deprecated wp_convert_bytes_to_hr function restored to it's original state :)

[audrasjb]

Patch looks good to go, marking this for commit.

[whyisjake]

In 48054:

I18N: Add i18n to size_format().

Add translatable strings to the units of the size_format() function.

Props Rahe, audrasjb, ocean90.

Fixes #50194.

Merged in https://core.trac.wordpress.org/changeset/48054.

[johnbillion]

We could go a step further here and implement _nx() with a placeholder for the numeric value instead of always appending the unit to the end.

Question: Are there actually any languages where the unit for the size of a value differs depending on the plurality of the number? (eg. is KB/KBS a thing?) I don't know, maybe this would be an unnecessary change.

[Rahe]

Hello,

I think that unit symbols are not sensitive to plural, we say 10 milliseconds and write 10ms, or 10 meters but write 10m.

According to this answer ​https://physics.stackexchange.com/a/384189

"Symbols for units are always written in roman (upright) type, irrespective of the type used in the rest of the text. The unit symbol shall remain unaltered in the plural and is not followed by a full stop except for normal punctuation, e.g. at the end of a sentence."