WordPress.org

Make WordPress Core

Opened 9 days ago

Last modified 3 days ago

#50194 accepted enhancement

Add i18n to size_format

Reported by: Rahe Owned by: audrasjb
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

Hello,

The units of the size_format function aren't translatable.
They are already translated on the network settings pages for the size of the upload folder or the size of the uploadable files.

Nicolas,

Change History (8)

This ticket was mentioned in PR #275 on WordPress/wordpress-develop by Rahe.


9 days ago

Change the size_format and wp_convert_bytes_to_hr to add translatable strings for the units

Trac ticket: https://core.trac.wordpress.org/ticket/50194

#2 @audrasjb
9 days ago

  • Keywords has-patch added

Hey,

This change makes sense to me.
I’d just suggest to add an additional translator comment when the file size is null, as the translation may be different for some locales in this specific case.

Maybe something like /* translators: File size in bytes, when the file size is null. */ ?

#3 @audrasjb
9 days ago

  • Milestone changed from Awaiting Review to 5.5

Let's move this ticket to milestone 5.5.

#4 @Rahe
8 days ago

Pull request updated

#5 @prbot
8 days ago

Rahe commented on PR #275:

Thank you for the review, everything is modified according to the comments

#6 @Rahe
8 days ago

PR updated :)

#7 @Rahe
6 days ago

Deprecated wp_convert_bytes_to_hr function restored to it's original state :)

#8 @audrasjb
3 days ago

  • Keywords commit added
  • Owner set to audrasjb
  • Status changed from new to accepted

Patch looks good to go, marking this for commit.

Note: See TracTickets for help on using tickets.