Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#50230 closed defect (bug) (reported-upstream)

CSS Validator error in wp-includes/css/dist/block-library/style.min.css

Reported by: aurepons's profile aurepons Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Editor Keywords:
Focuses: css Cc:

Description

I found two css errors when validating:

background-color is invalid at
.wp-gs .wp-block-button__link:not(.has-background)

margin-right:none is invalid property at
.wp-block-buttons.alignright .wp-block-button

Change History (7)

#1 @SergeyBiryukov
4 years ago

  • Component changed from General to Editor

#2 @audrasjb
4 years ago

Hi @aurepons and welcome to WordPress Trac,

Thanks for opening this ticket! Seems legit to me.

I reported the margin-right: none issue upstream on Gutenberg GitHub repository: https://github.com/WordPress/gutenberg/pull/22583

#3 @audrasjb
4 years ago

  • Keywords needs-patch removed

Concerning the other error, the related CSS declaration looks good to me:

.wp-gs .wp-block-button__link:not(.has-background) {
    background-color: var(--wp-block-core-button--color--background, var(--wp-color--primary, #32373c)); 
}

I think the validator is mistaken.

#4 @aurepons
4 years ago

Thank you for your fast response, probably you are right, but would be nice that wordpress validates with standard W3C tools and this is the only file that fails, try it at http://jigsaw.w3.org/css-validator/

#5 @audrasjb
4 years ago

@aurepons Thanks for the reply :)
Yes, I tested it with the W3C validator on my side, but unless I'm mistaken, it looks like the first case is an error from the W3C validation tool itself.

The second error is going to be fixed in WP 5.5 :)

#6 @aurepons
4 years ago

Thank you very much ;-)

#7 @ocean90
4 years ago

  • Focuses accessibility removed
  • Milestone Awaiting Review deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed
  • Version 5.4.1 deleted
Note: See TracTickets for help on using tickets.