Opened 4 years ago
Last modified 4 years ago
#50337 new enhancement
Build tools: Ensure built files have been updated or ignored in `src` directory.
Reported by: | peterwilsoncc | Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | 5.4 |
Component: | Build/Test Tools | Keywords: | has-patch |
Focuses: | Cc: |
Description
The npm run build:dev
command generates some files that need to be committed to the WordPress-Develop repository. It sure would be dandy if the build reported a failure if these files have not been updated.
Attachments (1)
Change History (6)
This ticket was mentioned in PR #324 on WordPress/wordpress-develop by peterwilsoncc.
4 years ago
#1
- Keywords has-patch added; needs-patch removed
#2
@
4 years ago
In 50337.diff:
- Create a new build for testing built files
- Exits
0
ifgit status --porcelain -- ':(exclude)package-lock.json'
is empty - Exits
1
ifgit status --porcelain -- ':(exclude)package-lock.json'
is not empty - I've ignored
package-lock.json
as it's operating system dependent.
Sample builds:
- out of date files, tested with [47920] reverted.
- up to date files
#3
@
4 years ago
- Summary changed from Build tools: Ensure built files have been updated in `src` directory. to Build tools: Ensure built files have been updated or ignored in `src` directory.
This ticket was mentioned in Slack in #core by peterwilsoncc. View the logs.
4 years ago
This ticket was mentioned in Slack in #core by peterwilsoncc. View the logs.
4 years ago
Note: See
TracTickets for help on using
tickets.
Trac ticket: https://core.trac.wordpress.org/ticket/50337#ticket