WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Last modified 5 years ago

#50337 new enhancement

Build tools: Ensure built files have been updated or ignored in `src` directory.

Reported by: peterwilsoncc Owned by:
Priority: normal Milestone: Awaiting Review
Component: Build/Test Tools Version: 5.4
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

The npm run build:dev command generates some files that need to be committed to the WordPress-Develop repository. It sure would be dandy if the build reported a failure if these files have not been updated.

Attachments (1)

50337.diff​ (1.4 KB ) - added by peterwilsoncc 6 years ago.

Download all attachments as: .zip

Change History (6)

This ticket was mentioned in ​PR #324 on ​WordPress/wordpress-develop by ​peterwilsoncc.
6 years ago #1

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/50337#ticket

@peterwilsoncc
6 years ago

#2 @peterwilsoncc
6 years ago

In 50337.diff​:

  • Create a new build for testing built files
  • Exits 0 if git status --porcelain -- ':(exclude)package-lock.json' is empty
  • Exits 1 if git status --porcelain -- ':(exclude)package-lock.json' is not empty
  • I've ignored package-lock.json as it's operating system dependent.

Sample builds:

#3 @peterwilsoncc
6 years ago

  • Summary Build tools: Ensure built files have been updated in `src` directory. → Build tools: Ensure built files have been updated or ignored in `src` directory.

This ticket was mentioned in ​Slack in #core by peterwilsoncc. ​View the logs.
6 years ago

This ticket was mentioned in ​Slack in #core by peterwilsoncc. ​View the logs.
5 years ago

Note: See TracTickets for help on using tickets.