WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#50570 closed defect (bug) (fixed)

Sitemap: Missing trailing slash in the url of the homepage

Reported by: chouby's profile Chouby Owned by: swissspidy's profile swissspidy
Milestone: 5.5 Priority: normal
Severity: minor Version: 5.5
Component: Sitemaps Keywords: has-patch commit
Focuses: Cc:

Description

The issue occurs when the homepage url includes a path. In this case, a trailing slash is added to the homepage canonical url. See ​https://github.com/WordPress/WordPress/blob/5.4.2/wp-includes/canonical.php#L195

It is missing in the sitemap.

Attachments (1)

50570.diff​ (655 bytes) - added by Chouby 4 years ago.

Download all attachments as: .zip

Change History (9)

@Chouby
4 years ago

#1 @Chouby
4 years ago

  • Keywords has-patch added

#2 @swissspidy
4 years ago

  • Milestone changed from Awaiting Review to 5.5
  • Owner set to swissspidy
  • Status changed from new to reviewing

Seems like a simple fix - thanks @Chouby!

This ticket was mentioned in ​Slack in #core-sitemaps by swissspidy. ​View the logs.
4 years ago

#4 @swissspidy
4 years ago

  • Severity changed from normal to minor

This ticket was mentioned in ​Slack in #core-sitemaps by swissspidy. ​View the logs.
4 years ago

#6 @swissspidy
4 years ago

  • Keywords commit added

#7 @swissspidy
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48472:

Sitemaps: Add missing slash when calling home_url() for consistency.

Props Chouby.
Fixes #50570.

This ticket was mentioned in ​Slack in #meta by tellyworth. ​View the logs.
4 years ago

Note: See TracTickets for help on using tickets.