Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#50650 closed task (blessed) (fixed)

Update two images from the s.w.org CDN for use in Block Patterns

Reported by: nrqsnchz's profile nrqsnchz Owned by: otto42's profile Otto42
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Editor Keywords:
Focuses: Cc:

Description

We are looking to increase the quality of two of the images from the s.w.org CDN in order to be able to use them in the block patterns to be released with 5.5

Please see https://github.com/WordPress/gutenberg/pull/23856 for more details.

The two images are:

https://s.w.org/images/core/5.3/Glacial_lakes,_Bhutan.jpg
https://s.w.org/images/core/5.3/Sediment_off_the_Yucatan_Peninsula.jpg

At their current size, they don't have enough resolution to be used in the proposed patterns. We'd like to replace them with higher-res versions.

I'm including the two higher-res version on this ticket. I've down-sized them to 1000px wide and ran them through image compression.

If there are other steps I should take to make them even smaller, please let me know.

cc @otto42, @kjellr, @youknowriadm, @mapk

Attachments (5)

Sediment_off_the_Yucatan_Peninsula.jpg (350.5 KB) - added by nrqsnchz 4 years ago.
Glacial_lakes,_Bhutan.jpg (245.6 KB) - added by nrqsnchz 4 years ago.
Glacial_lakes_Bhutan.jpg (95.6 KB) - added by nrqsnchz 4 years ago.
New, smaller size (1)
Sediment_off_the_Yucatan_Peninsula.2.jpg (133.0 KB) - added by nrqsnchz 4 years ago.
New, smaller size (2)
avatar.png (3.7 KB) - added by nrqsnchz 4 years ago.

Download all attachments as: .zip

Change History (21)

#1 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.5

#2 @SergeyBiryukov
4 years ago

  • Component changed from General to Editor

#3 follow-up: @Otto42
4 years ago

  • Type changed from defect (bug) to task (blessed)

Images in the CDN cannot be "replaced" so easily. That's why we always ask for final versions of them.

I can either replace the images and then the URLs for them will need to change, like adding a ?1 cache buster or similar, or the new images can be added with different names, like *-hires.* and the like. Pick your preference.

#4 @nrqsnchz
4 years ago

Thanks @Otto42

I can either replace the images and then the URLs for them will need to change, like adding a ?1 cache buster or similar, or the new images can be added with different names, like *-hires.* and the like. Pick your preference.

I think adding *-hires* to the file name will be the way to go. This way we don't risk breaking any paths by changing an URL that is already in use elsewhere.

#5 in reply to: ↑ 3 ; follow-ups: @SergeyBiryukov
4 years ago

Replying to Otto42:

Images in the CDN cannot be "replaced" so easily. That's why we always ask for final versions of them.

I can either replace the images and then the URLs for them will need to change, like adding a ?1 cache buster or similar, or the new images can be added with different names, like *-hires.* and the like. Pick your preference.

Would it make sense to upload the images under the same name, but under the core/5.5 directory (vs. core/5.3 for the old ones)?

#6 @nrqsnchz
4 years ago

Would it make sense to upload the images under the same name, but under the core/5.5 directory (vs. core/5.3 for the old ones)?

I think that would also work.

#7 in reply to: ↑ 5 @Otto42
4 years ago

Replying to SergeyBiryukov:

Would it make sense to upload the images under the same name, but under the core/5.5 directory (vs. core/5.3 for the old ones)?

That makes a lot of sense if these are going to be used specifically in 5.5 and above. Make sure we compress the images properly before putting them on the CDN first. Final images and all.

#8 in reply to: ↑ 5 @desrosj
4 years ago

Replying to SergeyBiryukov:

Would it make sense to upload the images under the same name, but under the core/5.5 directory (vs. core/5.3 for the old ones)?

I had the same thought here. I updated the PR on the Gutenberg repo to change the image paths to core/5.5.

#9 follow-up: @nrqsnchz
4 years ago

@Otto42

Make sure we compress the images properly before putting them on the CDN first. Final images and all.

Images have been compressed with ImageOptim, do you recommend I use a different tool?

#10 in reply to: ↑ 9 @Otto42
4 years ago

Replying to nrqsnchz:

do you recommend I use a different tool?

No, just wanting to make sure, since once they're on there, making changes is a royal pain to the point where I'd rather we put the right images up the first time.

#11 @nrqsnchz
4 years ago

Thanks for that clarification, @Otto42

I'll have more folks take a look to make sure these are as compressed as possible and will get back to you asap.

@nrqsnchz
4 years ago

New, smaller size (1)

@nrqsnchz
4 years ago

New, smaller size (2)

#12 @nrqsnchz
4 years ago

Ok @Otto42

With some help managed to get these down to 136 and 98KB, respectively. These are good to go.

Litle note: Trac renamed the file 'Sediment_off_the_Yucatan_Peninsula.2.jpg' adding a '2' before the file extension. This number should not appear in the final filename.

@nrqsnchz
4 years ago

#13 @nrqsnchz
4 years ago

Hi @Otto42,

As discussed in https://github.com/WordPress/gutenberg/pull/23881, please also include avatar.png (4KB) in the upload to the CDN.

#14 @Otto42
4 years ago

  • Owner set to Otto42
  • Status changed from new to accepted

#16 @nrqsnchz
4 years ago

Thank you so much @Otto42

Note: See TracTickets for help on using tickets.