WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Last modified 4 years ago

#50682 new defect (bug)

Set theme information popup in vertically middle.

Reported by: chetan200891's profile chetan200891 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.5
Component: Themes Keywords: has-screenshots has-patch
Focuses: ui, css, administration Cc:

Description

When we open theme info popup has more space on top. It should be vertically middle.

Attachments (4)

Theme-Overlay-Before.png​ (627.7 KB) - added by chetan200891 6 years ago.
Before
50682.diff​ (1.3 KB) - added by chetan200891 6 years ago.
Initial patch.
Theme-Overlay-After.png​ (672.5 KB) - added by chetan200891 6 years ago.
After applying patch.
50682.1.diff​ (1.3 KB) - added by sabernhardt 4 years ago.

Download all attachments as: .zip

Change History (8)

@chetan200891
6 years ago

Before

@chetan200891
6 years ago

Initial patch.

@chetan200891
6 years ago

After applying patch.

#1 @chetan200891
6 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
6 years ago

  • Focuses css administration added

#3 @SergeyBiryukov
6 years ago

  • Summary changed from Set theme inforrmation popup in vertically middle. to Set theme information popup in vertically middle.

@sabernhardt
4 years ago

#4 @sabernhardt
4 years ago

I like how you used the max-width, which makes the extra breakpoint unnecessary.

Because the toolbar currently is not fixed on mobile, I changed the top margin to zero for mobile sizes. (If it does become fixed, in the future, the margin should increase to 46 pixels.)

Note: See TracTickets for help on using tickets.