Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#50755 closed enhancement (fixed)

Change post type labels for Reusable Blocks in Block Editor.

Reported by: desaiuditd's profile desaiuditd Owned by: desrosj's profile desrosj
Milestone: 5.6 Priority: normal
Severity: normal Version: 5.0
Component: Editor Keywords: has-patch commit
Focuses: Cc:


Related pull request in Gutenberg that applies this change -

Above PR changes label for the Document settings tab in the sidebar in block editor. Instead of generic "Document" label, it will show the singular name label for the post type.

Currently, the label for reusable block is just "Block" which will conflict with the block settings tab in the sidebar and both will read "Block".

This might get confusing to users.

Similar to the PR in Gutenberg, we should change the labels for Reusable Block custom post type. So that it is distinguishable from the Block settings tab. "Reusable Block" is proposed as as label.

Attachments (5)

Change History (10)

#2 @peterwilsoncc
4 years ago

  • Milestone changed from Awaiting Review to 5.6

PR looks good to me, putting this on the 5.6 milestone for now as it seems likely the block-editor PR will be in by then.

#3 @desrosj
4 years ago

  • Keywords commit added; dev-feedback 2nd-opinion needs-testing needs-copy-review removed
  • Owner set to desrosj
  • Status changed from new to assigned
  • Version set to 5.0

Thanks @desaiuditd!

Looks like this has been around since the concept of reusable blocks was first merged into core in [43849] (and later frontported to trunk in [44215]).

#4 @desrosj
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 48829:

Editor: Update the post type labels for the reusable blocks post type.

Previously, the labels for the reusable block post type were just “block”. The document settings tab in the block editor has been changed to use the post type label specified instead to be more specific. Changing the reusable block post type labels to “reusable block” prevents two “Block” tabs from showing in the editor.

Props desaiuditd, peterwilsoncc.
Fixes #50755.

#5 @SergeyBiryukov
4 years ago

In 48846:

Tests: Update wp-api-generated.js to reflect the new "Reusable Blocks" post type label.

Follow-up to [48829].

See #50755.

Note: See TracTickets for help on using tickets.