Make WordPress Core

Opened 4 years ago

Last modified 4 years ago

#50766 closed defect (bug)

Not enough padding on "Warning: these page should not be the same!" — at Version 1

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by:
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Administration Keywords: good-first-bug has-screenshots has-patch needs-testing
Focuses: ui, css Cc:

Description (last modified by SergeyBiryukov)

  1. Go to Reading Settings.
  2. Assign the same page as Homepage and Posts page.
  3. You'll see the two messages: "Settings saved" and "Warning: these page should not be the same!".
  4. The first message has enough padding, while the second one does not.

This is caused by generic form table styles:

.form-table td p {
    margin-top: 4px;
    margin-bottom: 0;
}

taking precedence over

div.error p {
    margin: 0.5em 0;
    padding: 2px;
}

Adding a notice class to the message fixes the issue.

Note: This also applies to "Warning: these pages should not be the same as your Privacy Policy page!" directly below.

Change History (2)

@SergeyBiryukov
4 years ago

#1 @SergeyBiryukov
4 years ago

  • Description modified (diff)
Note: See TracTickets for help on using tickets.