WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#50862 closed defect (bug) (fixed)

Site Health not compatible with session-less PHP

Reported by: bgermann's profile bgermann Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: critical Version: 5.5
Component: Site Health Keywords: commit dev-reviewed
Focuses: Cc:

Description

#47320 introduced a check for PHP sessions in Site Health.
If PHP is built without the session extension the session_status call in class-wp-site-health.php throws a fatal error.

Please check for the function's existence before calling it so that WordPress 5.5 stays compatible with session-less PHP builds.

Change History (5)

#1 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 5.5

#2 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 48742:

Site Health: Check if session_status() exists before calling it.

Props bgermann.
Fixes #50862.

#3 @SergeyBiryukov
6 years ago

  • Keywords commit dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Good catch, welcome to WordPress Trac and thanks for the ticket!

Reopening for the 5.5 branch.

#4 @desrosj
6 years ago

  • Keywords dev-reviewed added; dev-feedback removed

#5 @desrosj
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 48746:

Site Health: Check if session_status() exists before calling it.

Merges [48742] to the 5.5 branch.
Reviewed by desrosj, SergeyBiryukov.
Props bgermann.
Fixes #50862.

Note: See TracTickets for help on using tickets.