Improve the structure format on the class-wp-media-list-table file

[Laxman Prajapati]

Improve the structure format of PHP code on the class-wp-media-list-table file for the understanding of which section are where closed.

[Laxman Prajapati]

Created patch.

[Laxman Prajapati]

Any update on this?

[hansjovisyoast]

When reviewing we (a few colleagues: @justinahinon and @noudwordpress and myself) noticed a few code standard issues in the patch, which we addressed in 51014-2.patch:

• The if statement on lines 272 to 276 was not correctly indented. It had one tab too many.
• Line 425 had a trailing whitespace.

There is one code standard issue left about a strict comparison:

FILE: src/wp-admin/includes/class-wp-media-list-table.php
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 656 | WARNING | Found: ==. Use strict comparisons (=== or !==).
     |         | (WordPress.PHP.StrictComparisons.LooseComparison)
-------------------------------------------------------------------------------------------------------------------

Since this is a pre-existing issue, where fixing it could change the behavior, we decided to leave it as is.

[helen]

I know this isn't a functional change but I don't really want to get into these types of changes here in late beta, marking for 5.7 early.

[audrasjb]

51014-2.patch looks good to me. Marking this for commit. Thanks all!

[SergeyBiryukov]

In 49975:

Coding Standards: Improve code layout in wp-admin/includes/class-wp-media-list-table.php.

This allows for better readability and easier understanding of where each section opens and closes.

Props laxman-prajapati, hansjovisyoast, audrasjb.
Fixes #51014.