Opened 4 years ago
Closed 4 years ago
#51014 closed defect (bug) (fixed)
Improve the structure format on the class-wp-media-list-table file
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.7 | Priority: | normal |
Severity: | normal | Version: | 4.0 |
Component: | Administration | Keywords: | good-first-bug has-patch early commit |
Focuses: | coding-standards | Cc: |
Description
Improve the structure format of PHP code on the class-wp-media-list-table file for the understanding of which section are where closed.
Attachments (2)
Change History (12)
#2
@
4 years ago
- Component changed from General to Administration
- Milestone changed from Awaiting Review to 5.6
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
#5
@
4 years ago
When reviewing we (a few colleagues: @justinahinon and @noudwordpress and myself) noticed a few code standard issues in the patch, which we addressed in 51014-2.patch
:
- The
if
statement on lines 272 to 276 was not correctly indented. It had one tab too many. - Line 425 had a trailing whitespace.
There is one code standard issue left about a strict comparison:
FILE: src/wp-admin/includes/class-wp-media-list-table.php ------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 656 | WARNING | Found: ==. Use strict comparisons (=== or !==). | | (WordPress.PHP.StrictComparisons.LooseComparison) -------------------------------------------------------------------------------------------------------------------
Since this is a pre-existing issue, where fixing it could change the behavior, we decided to leave it as is.
#6
@
4 years ago
- Keywords early added
- Milestone changed from 5.6 to 5.7
I know this isn't a functional change but I don't really want to get into these types of changes here in late beta, marking for 5.7 early.
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
4 years ago
Note: See
TracTickets for help on using
tickets.
Created patch.