Make WordPress Core

Opened 9 months ago

Closed 9 months ago

#51095 closed defect (bug) (fixed)

Twenty Nineteen: Fix CSS errors in style-editor.scss

Reported by: justinahinon Owned by: SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: minor Version: 5.6
Component: Bundled Theme Keywords: has-patch
Focuses: css Cc:


They are a few errors in https://github.com/WordPress/wordpress-develop/blob/master/src/wp-content/themes/twentynineteen/style-editor.scss for Twenty Nineteen theme.

Mostly an extra comma added before opening braces.

Attachments (2)

51095.diff (11.2 KB) - added by justinahinon 9 months ago.
51095.2.diff (863 bytes) - added by justinahinon 9 months ago.

Download all attachments as: .zip

Change History (8)

9 months ago

#1 @SergeyBiryukov
9 months ago

  • Milestone changed from Awaiting Review to 5.6
  • Summary changed from Fix CSS errors in Twenty Nineteen style-editor.scss to Twenty Nineteen: Fix CSS errors in style-editor.scss

#2 @justinahinon
9 months ago

Consider 51095.2.diff​ which is clean.

#4 @SergeyBiryukov
9 months ago

Introduced in [48602] / #49843.

#5 @SergeyBiryukov
9 months ago

  • Keywords has-patch added

#6 @SergeyBiryukov
9 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 48837:

Twenty Nineteen: Remove trailing commas after selectors in style-editor.scss.

Remove one empty CSS block.

Props justinahinon.
Fixes #51095.

Note: See TracTickets for help on using tickets.