Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#51122 closed defect (bug) (fixed)

Docs: add a mention about the use of `loading` attribute in `wp_get_attachment_image` function

Reported by: audrasjb's profile audrasjb Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.5.1 Priority: normal
Severity: normal Version: 5.5
Component: Media Keywords: has-patch
Focuses: docs Cc:

Description

wp_get_attachment_image Doc Block should mention that the loading attribute can be used in the $attr parameter.

This parameter was introduced in ticket #50425.

Attachments (1)

51122.diff (1.6 KB) - added by audrasjb 4 years ago.
Media: Add proper documentation about the use of the loading attribute in the attr parameter of wp_get_attachment_image

Download all attachments as: .zip

Change History (8)

@audrasjb
4 years ago

Media: Add proper documentation about the use of the loading attribute in the attr parameter of wp_get_attachment_image

#1 @audrasjb
4 years ago

  • Keywords has-patch added; needs-patch removed

#2 @audrasjb
4 years ago

  • Milestone changed from Awaiting Review to 5.5.1
  • Version set to 5.5

#3 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


4 years ago

#5 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48852:

Docs: Add documentation and a @since note about the loading attribute added to wp_get_attachment_image().

Follow-up to [48272].

Props audrasjb.
Fixes #51122.

#6 @SergeyBiryukov
4 years ago

In 48853:

Docs: Add a @since note about the $srcset and $sizes attributes added to wp_get_attachment_image().

Follow-up to [34855].

See #51122.

#7 @SergeyBiryukov
4 years ago

In 48854:

Docs: Add documentation and a @since note about the loading attribute added to wp_get_attachment_image().

Follow-up to [48272].

Props audrasjb.
Merges [48852] and [48853] to the 5.5 branch.
Fixes #51122.

Note: See TracTickets for help on using tickets.