Embeds: Add support for Deezer

[justinahinon]

Major music editor like Deezer doesn't have an embed block.
It would be good to have one for it.

[desrosj]

There is a set of questions regarding whitelisting oEmbed providers which that we ask are answered prior to considering a new embed service. Do you mind answering them @justinahinon? ​https://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers

[justinahinon]

Whitelisting Deezer oEmbed provider:

✅ Is the service is popular enough for core developers to have heard of it before? Is it “mainstream?”
Deezer is a quite popular service; with "14 million monthly active users, and 7 million paid subscribers as of January 2019".

Source: ​https://en.wikipedia.org/wiki/Deezer

[desrosj]

Replying to justinahinon:

✅ Is its oEmbed endpoint clearly established and properly documented? (Sometimes, they are just a developer’s pet project that may not be supported.)

Their seems to have a documented oEmbed endpoint ​here and ​here.

✅ Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being whitelisted?

When you add a link to a Deezer track in the editor, it is not recognized.

But I think it's because the structure of the endpoint URL for Deezer is slightly different from other services? ​https://www.deezer.com/plugins/player

It shoudl be possible to adapt this structure.

Hmm, it does not seem like that documentation is for an oEmbed service, but rather some type of widget embed code generator. In order to be added as a whitelisted oEmbed provider in Core, the ​oEmbed format needs to be supported.

I'm going to close this out as it does not appear that Deezer currently supports oEmbeds. But if new information presents itself, feel free to reopen!

[desrosj]

My apologies! I managed to locate documentation right after I closed the ticket. The second link @justinahinon provided above documents the oEmbed service for Deezer (it requires you to log in first, and I had not refreshed).

​https://developers.deezer.com/api/oembed-endpoint looks to document a valid oEmbed service.

I think that it should be alright to whitelist this service. Going to leave this for a bit to receive feedback from others before adding.

[dd32]

IMHO:

✅ Does the oEmbed endpoint work with WordPress’ oEmbed auto-discovery? If not, could it be made to work with additional HTML tags or attributes being whitelisted?

Deezer does not support ​oEmbed auto-discovery. Given 51132.patch​'s simplicity it appears that if they simply added support for auto-dscovery it would work.

✅ Does the service make an effort to build relationships with developers, such as through robust APIs?

The API documentation being hidden behind a login portal, which includes the below restriction tends to suggest to me that the answer to the above question is not a tick to me.

https://developers.deezer.com/termsofuse

IV. NON-COMMERCIAL USE
The Developer agrees that the use of the Services is strictly limited for a non-commercial purpose and in a non-commercial environment.

(That is not a guideline which WordPress can guarantee)

[desrosj]

I'm going to close this one out as a maybelater. If their services turn on oEmbed auto-discovery, and their terms of use are updated, we can reconsider.

[Hareesh Pillai]

#53030 was marked as a duplicate.