WordPress.org

Make WordPress Core

Opened 7 weeks ago

Last modified 6 weeks ago

#51249 new defect (bug)

design issue under customize input box for Schedule in 5.5.1

Reported by: rkradadiya Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Customize Keywords: needs-design-feedback has-patch 2nd-opinion
Focuses: ui, css Cc:

Description

I have found a design issue in Schedule your customization changes to publish.
Need improvement for design under the customize input box of Schedule.

Attachments (3)

2020-09-05_15h11_20.png (88.9 KB) - added by rkradadiya 7 weeks ago.
51249.patch (705 bytes) - added by Laxman Prajapati 7 weeks ago.
Created patch.
51249.1.patch (712 bytes) - added by Laxman Prajapati 7 weeks ago.
As per CSS coding standards, We have updated the patch. o, Can you please ignore "51249.patch" this one and please consider the correct solution is "51249.1.patch" this one.

Download all attachments as: .zip

Change History (11)

#1 @rkradadiya
7 weeks ago

  • Summary changed from design issue under customize input box of Schedule in 5.5.1 to design issue under customize input box for Schedule in 5.5.1

#2 @mukesh27
7 weeks ago

  • Keywords needs-testing removed
  • Type changed from feature request to defect (bug)

Hi there!

Yes there is alignment issue in fields and it is bug.

@Laxman Prajapati
7 weeks ago

Created patch.

#3 @Laxman Prajapati
7 weeks ago

  • Keywords has-patch added; needs-patch removed

#4 @SergeyBiryukov
7 weeks ago

  • Focuses css added

#5 @dlh
7 weeks ago

  • Milestone changed from Awaiting Review to Future Release
  • Version 5.5.1 deleted

Hi! Thanks for the ticket and the patch. Feedback from the design team would be great before moving this ticket into a milestone. The accessibility team might also want to weigh on based on their recent work in #48420.

Separately, please ensure that the patch follows the CSS coding standards for spacing and selector structure.

@Laxman Prajapati
7 weeks ago

As per CSS coding standards, We have updated the patch. o, Can you please ignore "51249.patch" this one and please consider the correct solution is "51249.1.patch" this one.

#6 follow-up: @mukesh27
6 weeks ago

Thanks for the patch @laxman-prajapati

Patch looks fine for me but i think margin top is not need to make top space. let's wait for design team feedback on this.

.date-time-fields .day-fields.clear,
.date-time-fields .time-fields.clear {
   margin-top: 5px;
} 

#7 in reply to: ↑ 6 @Laxman Prajapati
6 weeks ago

@mukesh27

Yes sure, If not need, we can remove it. I have added only for top spacing purpose.

Thanks,

Replying to mukesh27:

Thanks for the patch @laxman-prajapati

Patch looks fine for me but i think margin top is not need to make top space. let's wait for design team feedback on this.

.date-time-fields .day-fields.clear,
.date-time-fields .time-fields.clear {
   margin-top: 5px;
} 

#8 @rkradadiya
6 weeks ago

  • Keywords 2nd-opinion added
Note: See TracTickets for help on using tickets.