Opened 4 years ago
Last modified 4 years ago
#51249 new defect (bug)
design issue under customize input box for Schedule in 5.5.1
Reported by: | rkradadiya | Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | |
Component: | Customize | Keywords: | needs-design-feedback has-patch 2nd-opinion |
Focuses: | ui, css | Cc: |
Description
I have found a design issue in Schedule your customization changes to publish.
Need improvement for design under the customize input box of Schedule.
Attachments (3)
Change History (12)
#1
@
4 years ago
- Summary changed from design issue under customize input box of Schedule in 5.5.1 to design issue under customize input box for Schedule in 5.5.1
#5
@
4 years ago
- Milestone changed from Awaiting Review to Future Release
- Version 5.5.1 deleted
Hi! Thanks for the ticket and the patch. Feedback from the design team would be great before moving this ticket into a milestone. The accessibility team might also want to weigh on based on their recent work in #48420.
Separately, please ensure that the patch follows the CSS coding standards for spacing and selector structure.
@
4 years ago
As per CSS coding standards, We have updated the patch. o, Can you please ignore "51249.patch" this one and please consider the correct solution is "51249.1.patch" this one.
#6
follow-up:
↓ 7
@
4 years ago
Thanks for the patch @laxman-prajapati
Patch looks fine for me but i think margin top is not need to make top space. let's wait for design team feedback on this.
.date-time-fields .day-fields.clear, .date-time-fields .time-fields.clear { margin-top: 5px; }
#7
in reply to:
↑ 6
@
4 years ago
@mukesh27
Yes sure, If not need, we can remove it. I have added only for top spacing purpose.
Thanks,
Replying to mukesh27:
Thanks for the patch @laxman-prajapati
Patch looks fine for me but i think margin top is not need to make top space. let's wait for design team feedback on this.
.date-time-fields .day-fields.clear, .date-time-fields .time-fields.clear { margin-top: 5px; }
Hi there!
Yes there is alignment issue in fields and it is bug.