#51269 closed defect (bug) (fixed)
Document the $args parameter of wp_oembed_get()
Reported by: | SergeyBiryukov | Owned by: | helen |
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Embeds | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
Reported by @vakho114 on support forums.
wp_oembed_get()
has an $args
parameter, but it's not clarified which arguments exactly can be accepted.
Looking at the code, the array is passed to a few WP_oEmbed
methods:
WP_oEmbed::get_html()
WP_oEmbed::get_data()
WP_oEmbed::get_provider()
WP_oEmbed::fetch()
In WP_oEmbed::get_provider()
, the value of $args['discover']
determines whether to call the ::discover()
method if the oEmbed provider URL is not found in the built-in providers list.
In WP_oEmbed::fetch()
, $args
is merged with wp_embed_defaults()
, then $args['width']
and $args['height']
are passed to the provider URL.
So it looks like while any custom parameters can be passed, only width
, height
, and discover
are supported by default and should be documented as such.
Attachments (2)
Change History (7)
#1
@
4 years ago
- Keywords has-patch added
Documented the args per @SergeyBiryukov's notes for each method and filter.
#2
@
4 years ago
Hey there, 51269.3.diff
refreshes the previous patch against trunk and adds few docblock fixes concerning whitespaces et al :)
Otherwise, the changes make sense to me and look good to go.
#3
@
4 years ago
@SergeyBiryukov Can you do a code review of 51269.3.diff? Let us know if there are any other changes needed.
Documents the optional $args array elements to include width, height, and discovery.