Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#51606 closed defect (bug) (fixed)

Fix WP_Block_Supports class compatibility with Gutenberg-provided class

Reported by: oandregal's profile oandregal Owned by: oandregal's profile oandregal
Milestone: 5.6 Priority: normal
Severity: normal Version: 5.6
Component: Editor Keywords:
Focuses: Cc:

Description

The WP_Block_Supports class is a new addition that will come with 5.6 and acts as a register of the kind of features a block supports. It's already on WordPress 5.6 beta1 and we need to fix how core and the plugin play together in a number of situations:

  • plugin + WordPress < 5.6 (core has a WP_Block_Supports class)
  • plugin + WordPress >= 5.6 (core doesn't have a WP_Block_Supports class)

Change History (10)

This ticket was mentioned in PR #640 on WordPress/wordpress-develop by nosolosw.


4 years ago
#1

  • Keywords has-patch has-unit-tests added

Related:

The WP_Block_Supports class is a new addition that will come with 5.6 and acts as a register of the kind of features a block supports. It's already on WordPress 5.6 beta1 and we need to fix how core and the plugin play together in a number of situations:

plugin + WordPress < 5.6 (core has a WP_Block_Supports class)
plugin + WordPress >= 5.6 (core doesn't have a WP_Block_Supports class)

#2 @oandregal
4 years ago

  • Keywords has-patch has-unit-tests removed

There's a Pull Request to fix this at https://github.com/WordPress/wordpress-develop/pull/640

#3 @oandregal
4 years ago

The pull request has been udpated and all tests are passing. This is ready for review/commit.

youknowriad commented on PR #640:


4 years ago
#4

I won't be able to test this today but it's looking good to me if anyone wants to ship it :)

#5 @isabel_brison
4 years ago

  • Milestone changed from Awaiting Review to 5.6

#6 @youknowriad
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 49310:

Block Editor: Fix WP_Block_Supports class compatibility with Gutenberg-provided class.

When using WordPress trunk with Gutenberg master, there's an incompatibility causing
the dynamic block generated classes to be omitted.
This commit refactors the block supports to fix that problem.

Props nosolosw.
Fixes #51606.

talldan commented on PR #640:


4 years ago
#7

Thanks for fixing this ❤️

#8 @SergeyBiryukov
4 years ago

In 49312:

Docs: Correct DocBlock formatting for render_block().

Follow-up to [49310].

See #51606.

#10 @SergeyBiryukov
4 years ago

In 49540:

Coding Standards: Adjust formatting in WP_Block::render() for better readability.

Follow-up to [49310], [49539].

See #51606.

Note: See TracTickets for help on using tickets.