Context Navigation

← Previous Ticket
Next Ticket →

#51606 closed defect (bug) (fixed)

Fix WP_Block_Supports class compatibility with Gutenberg-provided class

Reported by:	oandregal	Owned by:	oandregal
Priority:	normal	Milestone:	5.6
Component:	Editor	Version:	5.6
Severity:	normal	Keywords:
Cc:		Focuses:

Description

The WP_Block_Supports class is a new addition that will come with 5.6 and acts as a register of the kind of features a block supports. It's already on WordPress 5.6 beta1 and we need to fix how core and the plugin play together in a number of situations:

plugin + WordPress < 5.6 (core has a WP_Block_Supports class)
plugin + WordPress >= 5.6 (core doesn't have a WP_Block_Supports class)

Change History (10)

This ticket was mentioned in PR #640 on WordPress/wordpress-develop by nosolosw.

6 years ago #1

Keywords has-patch has-unit-tests added

Gutenberg https://github.com/WordPress/gutenberg/pull/26356
Core patch https://core.trac.wordpress.org/ticket/51606#ticket

plugin + WordPress < 5.6 (core has a WP_Block_Supports class)
plugin + WordPress >= 5.6 (core doesn't have a WP_Block_Supports class)

#2 @oandregal
6 years ago

Keywords has-patch has-unit-tests removed

There's a Pull Request to fix this at https://github.com/WordPress/wordpress-develop/pull/640

#3 @oandregal
6 years ago

The pull request has been udpated and all tests are passing. This is ready for review/commit.

youknowriad commented on PR #640:

6 years ago #4

I won't be able to test this today but it's looking good to me if anyone wants to ship it :)

#5 @isabel_brison
6 years ago

Milestone Awaiting Review → 5.6

#6 @youknowriad
6 years ago

Resolution → fixed
Status assigned → closed

In 49310:

Block Editor: Fix WP_Block_Supports class compatibility with Gutenberg-provided class.

When using WordPress trunk with Gutenberg master, there's an incompatibility causing
the dynamic block generated classes to be omitted.
This commit refactors the block supports to fix that problem.

Props nosolosw.
Fixes #51606.