WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#51680 closed enhancement (fixed)

Add WP_MEMORY_LIMIT to WP Debug Data class

Reported by: nre's profile nre Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: good-first-bug has-patch has-dev-note
Focuses: administration Cc:

Description

Please add the constant WP_MEMORY_LIMIT to class WP_Debug_Data.

When I check the WP report in site health report (wp-admin/site-health.php?tab=debug), I see a list of all WordPress constants, amongst others there is WP_MAX_MEMORY_LIMIT. Both constants are part of the documentation (​https://wordpress.org/support/article/editing-wp-config-php/#increasing-memory-allocated-to-php)

What is missing there is the constant WP_MEMORY_LIMIT.
Apparently because it's not registered in Class WP_Debug_Data in wp-admin/includes/class-wp-debug-data.php.

/editing-wp-config-php/#increasing-memory-allocated-to-php).

Attachments (1)

51680.diff​ (576 bytes) - added by sanketchodavadiya 4 years ago.
Created patch.

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
4 years ago

  • Component changed from Administration to Site Health
  • Focuses administration added

This ticket was mentioned in ​Slack in #core by noisysocks. ​View the logs.
4 years ago

#3 @talldanwp
4 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

Hi @nre. The ticket was discussed during a triage session in slack:
​https://wordpress.slack.com/archives/C02RQBWTW/p1604381419364900

We agreed this sounds like a good thing to do!

@sanketchodavadiya
4 years ago

Created patch.

#4 @sanketchodavadiya
4 years ago

  • Keywords has-patch added; needs-patch removed
  • Version set to trunk

#5 @hellofromTonya
4 years ago

  • Version changed from trunk to 5.2

#6 @SergeyBiryukov
4 years ago

  • Milestone changed from Future Release to 5.7
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#7 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 49908:

Site Health: Add WP_MEMORY_LIMIT constant to debug info.

This complements the WP_MAX_MEMORY_LIMIT constant previously displayed there.

Props sanketchodavadiya, nre, talldanwp, noisysocks.
Fixes #51680.

#8 @audrasjb
4 years ago

  • Keywords needs-dev-note added

It would be nice to mention this change in the Miscellaneous Changes dev note.

Note: See TracTickets for help on using tickets.