Posting from email addresses with "hyphen" cannot be assigned to the user

[giannis1]

I am trying to post a message via email and HTML form to my Wordpress... and it doesn't assign the post to the user when the email address includes "hyphen"...when user's email address is without "hyphen" is assign perfectly the post to the User.

For example:

When a user@… submit a post via an external HTML form or by email, the post is assigned to the user. However, when user@… submit, it assigns the post to the admin.

Please help!

Thanks

John

[markjaquith]

giannis1, try the patch I uploaded.

[westi]

-1 to current patch.

Should we not use is_email and sanitize_email here - that way we have one rule for sanitizing all email addresses.

[markjaquith]

Using sanitize_email() and is_email()

[markjaquith]

Patch updated with Westi's suggestions.

[westi]

+1

New patch looks good to me.

[markjaquith]

(In [6212]) Properly sanitize e-mail addresses in wp-mail.php. Props giannis1. fixes #5169 for trunk

[Bobcat]

This patch doesn't work. All emails get posted by 'admin'. The problem is that sanitize_email returns "FromUserNameaddr@domain.com" when the rest of the code expects simply "addr@…" for looking-up the email address.

[markjaquith]

(In [6217]) Strip From/Reply-To from e-mail before sanitizing in wp-mail.php. Props Bobcat. fixes #5169

[Bobcat]

Nope, still doesn't work. It leaves the user name part of the From line; the part in quotes. e.g.: From line is:

From: "User Name" <addr@…>

But your code sets $author to:

UserNameaddr@domain.com

When the rest of the code needs:

addr@…

The easiest thing to do might be to use the regexp from your first patch to isolate the addr@… part, then call sanitize_email and is_email.

[Bobcat]

This patch (wp-mail.php.3.diff) isolates the email address before sending it to sanitize_email and is_email. I also improved the regexp to ignore strings that look like an email address if it's followed by a string in angle brackets (the string in angle brackets is the real email address); handles the case where a quoted string contains an "@" but isn't the real email address. I hope that makes sense.

[Bobcat]

Isolates email addr before sanitizing (fixed typo in comment)

[ryan]

See the regular expression for matching email addresses and weep.

​http://trac.wordpress.org/attachment/ticket/4616/4616b.diff

[ryan]

So let's see how the proposed patch for #4616 applies here, think about bumping the logic into a function like extract_email_address(), and maybe see if there's some squirrelmail code we can steal.

[ryan]

Alright, Bobcat's patch looks like a good fix for now and we can explore the bigger issues later.

[Bobcat]

Thank you. Patch tested with WP 2.3 by sending emails from addresses with and without hyphens in the email address.

[ryan]

(In [6280]) Allow hypens in email addresses. Props Bobcat. fixes #5169 for 2.3

[ryan]

(In [6281]) Fix email address parsing in wp-mail.php. Props Bobcat. fixes #5169