WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#51954 closed defect (bug) (fixed)

Twenty Twenty-One: use esc_url for footer WordPress link

Reported by: mukesh27's profile mukesh27 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.6.1 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: has-patch, fixed-major, twenty-twenty-one-1.1
Focuses: Cc:

Description

For twentytwentyone/footer.php WordPress link currently used esc_attr instead of esc_url

Attachments (1)

51954.diff​ (625 bytes) - added by mukesh27 4 years ago.
Patch.

Download all attachments as: .zip

Change History (8)

@mukesh27
4 years ago

Patch.

#1 @poena
4 years ago

This error is valid and embarrassing.

The patch would solve it -does it need to be made from the root directory, not wp-content?
I'll let a committer decide that.

Last edited 4 years ago by poena (previous) (diff)

#2 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.7

#3 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 49762:

Twenty Twenty-One: Use esc_url() for the WordPress.org link in footer.php.

Props mukesh27, poena.
Fixes #51954.

#4 @poena
4 years ago

  • Milestone changed from 5.7 to 5.6.1

#5 @desrosj
4 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to backport.

#6 @desrosj
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 49853:

Twenty Twenty-One: Use esc_url() for the WordPress.org link in footer.php.

Props mukesh27, poena.
Merges [49762] into the 5.6 branch.
Fixes #51954.

#7 @desrosj
4 years ago

  • Keywords twenty-twenty-one-1.1 added

Adding a custom keyword for querying tickets included in the Twenty Twenty-One version 1.1 release in the future.

Note: See TracTickets for help on using tickets.