locale 'de_AT' should be added to 'german' locales in remove_accents()

[nonverbla]

Hi there! My first WP ticket ever. I just noticed that the locale de_AT for ​Austria is not being handled in remove_accents(). So ü for example would be converted to the WP default of u instead of the correct ue. Here is the code (formatting.php, line 1299):

if ( in_array( $locale, array( 'de_DE', 'de_DE_formal', 'de_CH', 'de_CH_informal' ), true ) ) {
...

[ryokuhi]

Hello @nonverbla, and thanks for the enhancement suggestion.
We discussed this issue today during the accessibility team's weekly bug-scrub.
The team thinks that this is not an accessibility issue, so we are removing the focus.
Some team members think that this might be a good-first-bug, but we are leaving the final decision to the component maintainer.

[patopaiar]

Adds 'de_AT' to the array at wp-includes/formatting.php, line 1299

[patopaiar]

Hi! First time contributor here learning the ropes of the process.
Added 'de_AT' first to order alphabetically (?)

[mukesh27]

Updated patch.

[mukesh27]

Thank you for the patch! The system needs diff files to be generated against WordPress development files and not built versions of WordPress.

52110.diff​ refreshes the patch against trunk.

[patopaiar]

The system needs diff files to be generated against WordPress development files and not built versions of WordPress.

Thank you for pointing this out to me. Is there any link or resource I can read more about to understand what to do instead of what I did?
I understand the concept of what you're saying, but not how to achieve it, if that makes sense. Thank you in advance.

[audrasjb]

Welcome @patopaiar ! You can checkout our ​Core handbook to learn more about working with patches and GIT.

I tested the proposed patch: it still applies cleanly against trunk and it looks good to me.

Marking this for commit. Thanks all.

[patopaiar]

Hey @audrasjb

Thanks for the info and reviewing and accepting my patch! I was using TortoiseSVN to create it.
Could it be the issue was it wasn't created from the root?

[ocean90]

In 49967:

I18N: Add support for German (Austria) locale in remove_accents().

Props patopaiar, nonverbla.
Fixes #52110.