WordPress.org

Make WordPress Core

Opened 4 weeks ago

Last modified 11 days ago

#52110 accepted enhancement

locale 'de_AT' should be added to 'german' locales in remove_accents()

Reported by: nonverbla Owned by: audrasjb
Milestone: 5.7 Priority: normal
Severity: trivial Version: 5.5.3
Component: I18N Keywords: good-first-bug has-patch commit
Focuses: Cc:

Description

Hi there! My first WP ticket ever. I just noticed that the locale de_AT for Austria is not being handled in remove_accents(). So ü for example would be converted to the WP default of u instead of the correct ue. Here is the code (formatting.php, line 1299):

if ( in_array( $locale, array( 'de_DE', 'de_DE_formal', 'de_CH', 'de_CH_informal' ), true ) ) {
...

Attachments (2)

52110-patch.patch (572 bytes) - added by patopaiar 4 weeks ago.
Adds 'de_AT' to the array at wp-includes/formatting.php, line 1299
52110.diff (579 bytes) - added by mukesh27 4 weeks ago.
Updated patch.

Download all attachments as: .zip

Change History (11)

This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.


4 weeks ago

#2 @ryokuhi
4 weeks ago

  • Component changed from Formatting to I18N
  • Focuses accessibility removed

Hello @nonverbla, and thanks for the enhancement suggestion.
We discussed this issue today during the accessibility team's weekly bug-scrub.
The team thinks that this is not an accessibility issue, so we are removing the focus.
Some team members think that this might be a good-first-bug, but we are leaving the final decision to the component maintainer.

#3 @SergeyBiryukov
4 weeks ago

  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to 5.7

@patopaiar
4 weeks ago

Adds 'de_AT' to the array at wp-includes/formatting.php, line 1299

#4 @patopaiar
4 weeks ago

Hi! First time contributor here learning the ropes of the process.
Added 'de_AT' first to order alphabetically (?)

#5 @voboghure
4 weeks ago

  • Keywords has-patch added; needs-patch removed

@mukesh27
4 weeks ago

Updated patch.

#6 @mukesh27
4 weeks ago

Thank you for the patch! The system needs diff files to be generated against WordPress development files and not built versions of WordPress.

52110.diff refreshes the patch against trunk.

#7 @patopaiar
4 weeks ago

The system needs diff files to be generated against WordPress development files and not built versions of WordPress.

Thank you for pointing this out to me. Is there any link or resource I can read more about to understand what to do instead of what I did?
I understand the concept of what you're saying, but not how to achieve it, if that makes sense. Thank you in advance.

#8 @audrasjb
11 days ago

  • Keywords commit added
  • Owner set to audrasjb
  • Status changed from new to accepted

Welcome @patopaiar ! You can checkout our Core handbook to learn more about working with patches and GIT.

I tested the proposed patch: it still applies cleanly against trunk and it looks good to me.

Marking this for commit. Thanks all.

#9 @patopaiar
11 days ago

Hey @audrasjb

Thanks for the info and reviewing and accepting my patch! I was using TortoiseSVN to create it.
Could it be the issue was it wasn't created from the root?

Note: See TracTickets for help on using tickets.