Missing option to change multiple users to "No role for this site"

[bonniebeeman]

It is often critical for the security of a WordPress site to change User roles en masse, but the option to change a user role to "No role for this site" is missing from WordPress User option dropdown list.

[bonniebeeman]

Missing option to change user role to "no role for this user"

[sabernhardt]

Hi @bonniebeeman and welcome to Trac!

"None" or "No role for this site" must be a plugin option, as it is not one of the ​standard WordPress roles.

If that plugin is User Role Editor, you could request that they add it as an option to the Change role dropdown:
​User Role Editor support forum

Right now with that plugin, though, you could select all Subscriber-level users and select Subscriber in the Revoke role dropdown. That changes users' role to "None" if the revoke role matches their previous role.

[johnbillion]

"No role for this site" is a core option, it's only available when editing a single user though. I don't see any reason for it not to be available as a bulk action on the Users screen.

[sabernhardt]

My mistake for not checking the Edit User screen. In addition to the bulk edit, would it be worth including this in the dropdown on the Add New User screen?

[ovidiul]

Added the "— No role for this site — " to the bulk user roles change; probably the best implementation would be to add the default role None to the wp_user_roles db option, but that would have it's own complexities

[johnbillion]

Thanks for the patch @ovidiul !

[johnbillion]

52238.diff​ adjusts the patch slightly so the user's role gets correctly set to an empty string instead of none.

Steps to test:

1. Visit the Users screen in the admin area
2. Check the checkbox next to a user
3. Select "No role for this site" in the "Change role to" dropdown
4. Click the "Change" button
5. Confirm the user's role is marked as "None"
6. Confirm the user shows up when you click the "No role" filter at the top of the Users screen

This isn't something we can add an automated test for (without E2E tests) as it's tightly coupled to the request.

[jeroenrotty]

Tested the latest patch and can confirm the testing steps work as described by @johnbillion. None gets applied correctly in bulk.

[johnbillion]

In 50228:

Users: Allow the role of users to be bulk changed to no role from the Users listing screen.

This option is already available when editing an individual user, but it was previously missing from the bulk actions.

Props bonniebeeman, sabernhardt, ovidiul, jeroenrotty

Fixes #52238

[johnbillion]

In 50229:

Users: Coding standards fixes after [50228].

See #52238