Make filename checks less strict in `wp_image_src_get_dimensions`

[joemcgill]

As a follow up to #51865, @ianmjones noted that wp_image_src_get_dimensions checks for the entire upload path when attempting to get the dimensions of full size images. For many reasons, this check can fail if the path has been changed. To make this less strict, we should be able to check to make sure the basename matches rather than the whole uploads path.

See the original comment.

This modifies the check for full size files so that only the basename is compared with the image src to avoid misses whenever the src path has been modified.

Fixes: https://core.trac.wordpress.org/ticket/52417
Props ianmjones

[antpb]

Took a look at the patch and it makes sense and looks good to me, @joemcgill ! Tests are passing all around too.

Hello,

As per the PHP Coding Standards document - ​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions can we use Yoda Conditions here?

if ( strpos( $image_src, wp_basename( $image_meta['file'] ) ) !== false ) {

Replace to

if ( false !=== strpos( $image_src, wp_basename( $image_meta['file'] ) ) ) {

[mukesh27]

needs-refresh for the patch.

As per the PHP Coding Standards document - ​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions can we use Yoda Conditions here?

Yoda Conditions doesn't apply in this case. Why? There's no variable on either side of the conditional expression. Instead, the expression compares a boolean literal false to a final result of the functions.

IMO the code is well-formed and understandable.

[joemcgill]

Refreshed the patch to deal with merge conflicts after [50136].

[hellofromTonya]

Patch looks good @joemcgill. +1 for commit.

[joemcgill]

In 50144:

Media: Make filename checks less strict in 'wp_image_src_get_dimensions'.

This modifies the check for full size files so that only the basename is compared with the image src to avoid misses whenever the src path has been modified.

Props ianmjones.
Fixes: #52417.

Fixed in https://core.trac.wordpress.org/changeset/50144