Opened 4 years ago
Closed 4 years ago
#52452 closed defect (bug) (fixed)
Border color plugin update row incorrect color on mobile
Reported by: | afragen | Owned by: | ryelle |
---|---|---|---|
Milestone: | 5.7 | Priority: | normal |
Severity: | normal | Version: | 5.7 |
Component: | Plugins | Keywords: | has-screenshots has-patch commit |
Focuses: | ui, css, administration | Cc: |
Description (last modified by )
When an activated plugin has an update the update row has a background color of #f0f6fc
As of r50025 the background color has changed to #fff. This is in wp-admin/css/list-tables.css:2090
On mobile this results in a white block on the left of the update row.
Attachments (4)
Change History (23)
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
4 years ago
This ticket was mentioned in PR #980 on WordPress/wordpress-develop by ryelle.
4 years ago
#7
- Keywords has-patch added
This also removes a redundant rule which is immediately overwritten.
Screenshot of this branch:
<img width="421" alt="Screen Shot 2021-02-05 at 6 37 15 PM" src="https://user-images.githubusercontent.com/541093/107100063-3df98f80-67e1-11eb-9e72-69e2ad719ae8.png">
Trac ticket: https://core.trac.wordpress.org/ticket/52452
#8
@
4 years ago
Added a PR to fix the background color - there's a new screenshot in the PR description.
#11
@
4 years ago
- Owner set to ryelle
- Resolution set to fixed
- Status changed from new to closed
In 50237:
This ticket was mentioned in Slack in #core by monikarao. View the logs.
4 years ago
#14
@
4 years ago
As this bug was found in trunk, I could not reproduce it on current 5.6.1 version.
I have tested it on 5.7 beta2 version and could verify that the white block is not shown. Tested on different device emulators + real mobile (Galaxy S6).
#15
@
4 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
@ryelle it seems there's a part 2 to this. Referring to what happens after the update is done.
Seems like an easy fix. Add .plugins .active.updated + .plugin-update-tr:before
to the selectors in list-tables.css:2084
Hello @afragen,
Thank you for opening this ticket.
As this change occurred from Ticket #49999 and in changeset [50025], pinging @ryelle for visibility and opinion.