Opened 4 years ago
Last modified 4 years ago
#52471 new enhancement
Site Health Upload-related INI values could use consistent formatting
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | |
Component: | Site Health | Keywords: | has-patch close 2nd-opinion |
Focuses: | Cc: |
Description
In #50038, we added a new section to Site Health -> Info section to show upload-related limits.
Currently, it does not show the information in a consistent way. It shows values like 128M
, 2G
, and 128 MB
.
I would like to suggest to tweak this to use size_format
function to properly format them. We already use wp_convert_hr_to_bytes
function to parse INI-style values (128M
, 2G
, 2M
, etc); they just need some formatting.
Despite being a smaller diff, I suppose 5.7 is too early to target this, assuming this gets accepted of course.
Attachments (3)
Change History (4)
#1
@
4 years ago
- Keywords close 2nd-opinion added
Hi there, thanks for the ticket and the patch!
Pretty much like in #46664, I think the purpose of the Site Health Info screen is to provide raw data as reported by PHP for debugging purposes, so we'd want to avoid any modifications of the displayed data here.
Before this change