Opened 4 years ago
Last modified 6 months ago
#52543 assigned defect (bug)
Twenty Twenty: Vendor prefix build steps are missing configuration
Reported by: | ryelle | Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch reporter-feedback |
Focuses: | Cc: |
Description
When building Twenty Twenty, there are two steps that run over CSS files, a vendor prefixer and RTL conversion. The vendor prefixer uses postcss, but there is no postcss.config.js
file. It looks like this wasn't brought over from github when the theme was initially committed. When build
is run currently, we can see an error:
You did not set any plugins, parser, or stringifier. Right now, PostCSS does nothing. Pick plugins for your case on https://www.postcss.parts/ and use them in postcss.config.js.
We should either remove the postcss commands from build
(if so, we can also remove the dependencies), or add in a postcss config.
Attachments (1)
Change History (6)
#2
@
7 months ago
- Owner set to karmatosed
- Status changed from new to accepted
This feels like an easy patch to get in as it helps the compiling and wasn't brought over from git. I am going to assign to myself to test and see about bring on.
#3
@
7 months ago
- Keywords reporter-feedback added
Looking at running this it changes the stylesheets by removing vendor prefixes on compiling. As this has been a while, I am going to check this is desirable before commit.
What I see is it removes on compiling with this patch:
- -moz-user-select: none; - -ms-user-select: none;
Basic postcss + autoprefixer config in package.json