WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Last modified 8 months ago

#52621 new defect (bug)

Leave site? / Save alert

Reported by: garbagedisco's profile garbagedisco Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 5.6.3
Component: Editor Keywords: needs-patch
Focuses: ui Cc:

Description

The pop up alert for "Changes may not be saved" is still present in 5.6.2

Site example:
The classic editor plugin is installed on the site,
Gutenberg is disabled completely
Custom post types which don't have the WYSIWYG editor on still have this message appearing.

This bug was introduced in 5.6.1 and said to be fixed in 5.6.2 - it's still in the codebase

Attachments (1)

Screenshot 2021-02-23 at 08.30.18.png​ (107.8 KB) - added by garbagedisco 4 years ago.

Download all attachments as: .zip

Change History (10)

@garbagedisco
4 years ago

#1 @SergeyBiryukov
4 years ago

  • Component changed from General to Editor
  • Version changed from trunk to 5.6.2

Hi there, welcome to WordPress Trac! Thanks for the report.

Just linking to the previous ticket here: #52440.

#2 @garbagedisco
4 years ago

  • Component changed from Editor to General
  • Version changed from 5.6.2 to trunk

The fix here seems to work for anyone with this issue:

https://core.trac.wordpress.org/ticket/52440#comment:52

#3 @SergeyBiryukov
4 years ago

  • Component changed from General to Editor
  • Version changed from trunk to 5.6.2

#4 @SergeyBiryukov
4 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.8

Yeah, the intention of [50232] was to restore the functionality as it was in 5.6, but it looks like that can still unnecessarily display the message under some circumstances, as noted in comment:27:ticket:52440.

So apparently the enhanced fix suggested in comment:28:ticket:52440 would still be preferable here.

Moving to 5.8 for now, pending a patch. When a patch is available and tested, it can potentially go into the next minor release.

This ticket was mentioned in ​Slack in #core by desrosj. ​View the logs.
4 years ago

#6 @archon810
4 years ago

As I mentioned in https://core.trac.wordpress.org/ticket/52440#comment:41, the solution there wasn't working for us either and I had to resort to the functions.php fix. Glad someone else pushed to have a new ticket for this and I'm not the only one with the issue.

#7 @bradley2083
4 years ago

I've tried the functions.php fix and it isn't working for me. I have two custom post types registered in plugins I've added and those both support title, editor and excerpt. I also see the issue if I delete those plugins (and therefore post types).

#8 follow-up: @JeffPaul
4 years ago

  • Milestone changed from 5.8 to Future Release

With 5.8 Beta 1 next week and no patch/PR on this ticket, I'm going to punt this to Future Release. Once a patch/PR is available this ticket can be added back to a numbered milestone.

#9 in reply to: ↑ 8 @hcgernhardtiii
8 months ago

  • Version changed from 5.6.2 to 5.6.3

Replying to JeffPaul:

With 5.8 Beta 1 next week and no patch/PR on this ticket, I'm going to punt this to Future Release. Once a patch/PR is available this ticket can be added back to a numbered milestone.

This issue still exists in 6.5.3. Can anyone confirm if any of the aforementioned fixes work?

Note: See TracTickets for help on using tickets.