WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 38 hours ago

#52779 new defect (bug)

Error with saved blocks

Reported by: lumay Owned by:
Milestone: 5.7.3 Priority: normal
Severity: normal Version: 5.7
Component: Editor Keywords: dev-feedback
Focuses: Cc:

Description

After update to WordPress 5.7 there is no possibility to use saved blocks without make changes in original bock. That's mean I would like to use saved block, make some changes when I've added it to the post and didn't make change in saved block – it is not posible now. Could you please give me a tip how to use previous option of using saved blocks?

Attachments (2)

Zrzut ekranu 2021-03-11 o 15.36.55.png (52.3 KB) - added by lumay 2 months ago.
saved block without option to use without changes in source
Zrzut ekranu 2021-03-19 o 07.54.20.png (465.8 KB) - added by lumay 8 weeks ago.

Download all attachments as: .zip

Change History (20)

@lumay
2 months ago

saved block without option to use without changes in source

#1 @peterwilsoncc
2 months ago

  • Component changed from General to Editor
  • Keywords reporter-feedback added

Hi @lumay and welcome back to trac!

I've attempted to reproduce this in a vanilla WordPress install (no plugins running Twenty Twenty One), are you able to provide some additional steps to reproduce?

The steps I took are as follows:

  • Create a new post
  • Add a paragraph block, save as reusable block
  • Publish post
  • Create another new post
  • Insert reusable block
  • Publish the post
  • The shared block was visible.

It would help if you could provide the following:

  • The type of post you created (post, page, custom post type)
  • Whether you had published the original post
  • The type of shared/reusable block you were trying to insert

Thanks for the report.

#2 @lumay
2 months ago

Hi @peterwilsoncc thx for your answer. Please try do this steps:

Create any new reusable block for ex. with text
Insert this reusable block to the post and try to edit it without save changes to origin reusable block – there is no option to do that. If you change something in reusable block it will be applied in every post where it is - and it is ok.
But before we're able to to add reusable block to the post and change it as a comon block without saving changes in original reusable block - we could use it as a tamplate :)

#3 @lumay
2 months ago

When I'm trying to publish post there is option to uncheck "save reusable block", but when I've unchecked it button save is not active - there in no possibilities to publish changed resusable block witjhout to saving it in origin template

#4 @lumay
2 months ago

  • Keywords reporter-feedback removed

#5 @lumay
2 months ago

  • Keywords dev-feedback added

#6 @desrosj
2 months ago

  • Milestone changed from Awaiting Review to 5.7.1

I'm moving this to 5.7.1 to continue investigating. There are some other reports about strange behavior with reusable blocks (#52790), so I'd like to get to the bottom of this.

#7 @peterwilsoncc
8 weeks ago

Thanks for the further information @lumay, I think I have reproduced it now

The steps I took are as follows:

  • Create a new post
  • Add a paragraph block, save as reusable block
  • Publish post
  • Create another new post
  • Insert reusable block
  • Click 'save'
  • Uncheck 'save reusable block'
  • Click 'publish', this fails

In the console, clicking publish in the final step is showing the error Uncaught TypeError: _this2.props.setEntitiesSavedStatesCallback is not a function in the console twice.

I'd cleared local and session storage prior to starting to make sure there wasn't anything there getting in the way.

This ticket was mentioned in Slack in #core-editor by peterwilsoncc. View the logs.


8 weeks ago

#9 @lumay
8 weeks ago

Thanks @peterwilsoncc for additional checking. I've got there also additional Errors in console. If it help you?

[Error] WebSocket connection to 'wss://public-api.wordpress.com/pinghub/wpcom/me/newest-note-data' failed: Unexpected response code: 403
[Error] Error while parsing the 'sandbox' attribute: 'allow-presentation' is an invalid sandbox flag.
	xd (react-dom.min.js:17:421)
	hj (react-dom.min.js:117:334)
	Sh (react-dom.min.js:152:402)
	Th (react-dom.min.js:152:290)
	tj (react-dom.min.js:152:155)
	Te (react-dom.min.js:146:154)
	Te
	(anonimowa funkcja) (react-dom.min.js:61)
	unstable_runWithPriority (react.min.js:25:262)
	Pg (react-dom.min.js:61)
	ha (react-dom.min.js:60:454)
	(anonimowa funkcja) (react-dom.min.js:236)
	Ei (react-dom.min.js:41:91)
	Ei

#10 @paaljoachim
8 weeks ago

Actually that is somewhat similar to what I am mentioning here where I am comparing and old and new Reusable block methods. https://github.com/WordPress/gutenberg/issues/29178

The problem is if one does not want to save a change to a Reusable block is that it gets stuck in the Save/Publish process and one is not able to move onward.

At the moment we are looking at this for Full Site Editing which should also be transferred over to Reusable blocks. https://github.com/WordPress/gutenberg/issues/29577#issuecomment-802732673

Last edited 8 weeks ago by paaljoachim (previous) (diff)

#11 @lumay
8 weeks ago

So, the solution is delete all old reusable blocks and create them again? - [UPDATE] No it isn't sollution :( Doesn't work.
Before was better option to convert reusable block on common block, when it was added to the post.
When I've converted reusable block on common block I was sure I didn't change source of reusable block.

Last edited 8 weeks ago by lumay (previous) (diff)

#12 @paaljoachim
8 weeks ago

@youknowriad and @matveb
Let's get a very simple solution in place. If the user unchecks to save changes to Reusable block then the save change should be ignored but one still needs to be able to go through the process of saving and then clicking to Publish.

@lumay at the moment it is also too easy to accidentally make a change to a Reusable block.
A click through method is being explored. When clicking a reusable block, the first click selects the parent container (Reusable block). The second click would then select one of the inner blocks. https://github.com/WordPress/gutenberg/issues/29337

Both of the above issues (quick fix for saving mechanism) and (click through method) will hopefully be included in WordPress 5.7.1. Making it easier for the many folks struggling with this aspect of the new Reusable block feature.

Last edited 8 weeks ago by paaljoachim (previous) (diff)

This ticket was mentioned in Slack in #forums by t-p. View the logs.


7 weeks ago

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


7 weeks ago

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


6 weeks ago

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


5 weeks ago

#17 @audrasjb
5 weeks ago

  • Milestone changed from 5.7.1 to 5.7.2

Moving to Milestone 5.7.2 as WordPress 5.7.1 Release Candidate 1 is planned for today.

#18 @dd32
38 hours ago

  • Milestone changed from 5.7.2 to 5.7.3

WordPress 5.7.2 has been released, moving open tickets to 5.7.3

Note: See TracTickets for help on using tickets.