WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#53017 closed enhancement (fixed)

i18n: Missing context on some strings from plugin/theme upgrade screen

Reported by: dimadin's profile dimadin Owned by: davidbaumwald's profile davidbaumwald
Milestone: 5.8 Priority: normal
Severity: normal Version: 5.5
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

In [48390], plugins and themes were allowed to be updated from a uploaded .zip file. However, few strings that were introduced at that time lack context that would distinguish whether they are for plugin or theme update. Similar strings for ​plugin or ​theme update do have context.

Change History (4)

#2 @SergeyBiryukov
4 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.8
  • Owner set to davidbaumwald
  • Status changed from new to assigned

Good catch, thanks for the ticket! The PR looks good to me.

#3 @davidbaumwald
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 50705:

I18N: Add context to strings when updating a plugin or theme with a ZIP package.

After [48390], plugins and themes can be updated with an uploaded ZIP file. Strings were added for comparing the "current" and "uploaded" versions of a plugin or theme, but lacked context for each as to the object being referenced. This change adds a plugin or theme context to each of these strings for disambiguation.

Props dimadin, SergeyBiryukov.
Fixes #53017.

Note: See TracTickets for help on using tickets.