Context Navigation

← Previous Ticket
Next Ticket →

#53017 closed enhancement (fixed)

i18n: Missing context on some strings from plugin/theme upgrade screen

Reported by:	dimadin	Owned by:	davidbaumwald
Priority:	normal	Milestone:	5.8
Component:	I18N	Version:	5.5
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:

Description

In [48390], plugins and themes were allowed to be updated from a uploaded .zip file. However, few strings that were introduced at that time lack context that would distinguish whether they are for plugin or theme update. Similar strings for plugin or theme update do have context.

Change History (4)

This ticket was mentioned in PR #1189 on WordPress/wordpress-develop by dimadin.

5 years ago #1

https://core.trac.wordpress.org/ticket/53017

#2 @SergeyBiryukov
5 years ago

Keywords commit added
Milestone Awaiting Review → 5.8
Owner set to davidbaumwald
Status new → assigned

Good catch, thanks for the ticket! The PR looks good to me.

#3 @davidbaumwald
5 years ago

Resolution → fixed
Status assigned → closed

In 50705:

I18N: Add context to strings when updating a plugin or theme with a ZIP package.

After [48390], plugins and themes can be updated with an uploaded ZIP file. Strings were added for comparing the "current" and "uploaded" versions of a plugin or theme, but lacked context for each as to the object being referenced. This change adds a plugin or theme context to each of these strings for disambiguation.

Props dimadin, SergeyBiryukov.
Fixes #53017.

dimadin commented on PR #1189:

5 years ago #4

Merged into core in https://core.trac.wordpress.org/changeset/50705.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core