WordPress.org

Make WordPress Core

Opened 5 months ago

Last modified 4 months ago

#53076 accepted enhancement

Press This: Add filters to allow custom Press This plugins

Reported by: kraftbj Owned by: kraftbj
Milestone: Future Release Priority: normal
Severity: normal Version: 4.9
Component: Editor Keywords: has-patch needs-testing needs-testing-info
Focuses: Cc:

Description

The Press This feature of WordPress was spun out of Core in 4.9 as into a "canonical plugin". The Core side code presumes the canonical plugin is the only implementation.

If a site owner wants a custom version of Press This, they are required to hack the plugin in some way (set the version super high and edit the files, replace it with something of a high version, etc to ensure the plugin is updated back to stock by WordPress).

This also limits what site owners can do—selective versions of Press This based on who is logged in, A/B tests of different Press This's, etc.

Request a few filters added to wp-admin/press-this.php to allow for alternative implementations.

Change History (5)

This ticket was mentioned in PR #1207 on WordPress/wordpress-develop by kraftbj.


5 months ago

  • Keywords has-patch added

Adds filters to wp-admin/press-this.php to allow for custom Press This plugins to be used without special hacks.

Trac ticket: https://core.trac.wordpress.org/ticket/53076

This ticket was mentioned in Slack in #core by chaion07. View the logs.


4 months ago

#3 @poena
4 months ago

  • Keywords needs-testing needs-testing-info added

Hi
This ticket was brought up during a bug scrub, but we were not sure how to continue to test this without first creating a custom press-this plugin to test the filter with.

Do you have a sample plugin code for this purpose? Or other testing instructions?

#4 @poena
4 months ago

Hi @kraftbj will you be able to provide further testing instructions before the 5.8 feature freeze?

#5 @kraftbj
4 months ago

  • Milestone changed from 5.8 to Future Release
  • Owner set to kraftbj
  • Status changed from new to accepted

Hi @poena. I'll move it out of the milestone; a bit of a chicken and the egg where I was looking at add the filters before having the plugin to utilize them, but makes sense to wait.

Note: See TracTickets for help on using tickets.