![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 19 years ago
Closed 19 years ago
#5312 closed enhancement (fixed)
wp-admin/includes/image.php overhaul
| Reported by: | DD32 | Owned by: | westi |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.5 |
| Component: | Administration | Version: | 2.5 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
This ticket relates to #4151, #4709 and #5304
I've cleaned the file up to reduce duplicated code, Added PHPDoc comments, and included mentioned tickets within the cleanup.
Notes:
function get_udims()duplicatedwp_shrink_dimensions(), Switched it to usewp_shrink_dimensions()instead.
- It appears that
get_udims()is not used anywhere else in WP.
- depreciated 3rd param($effect) to
wp_create_thumbnail()as it isnt used within the function.
- IMAGETYPE_XXX introduced with PHP 4.3.0 it appears, Added to compat.php.
- The inline documentation may not be the best, And doesnt include Long descriptions for most of the functions.
- Most functions should return a WP_Error object instead on error, For most compatibilit current patch follows previous error handling route.
Attachments (1)
Change History (3)
Note:
See TracTickets
for help on using tickets.
image.php cleanup