Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#5312 closed enhancement (fixed)

wp-admin/includes/image.php overhaul

Reported by: dd32's profile DD32 Owned by: westi's profile westi
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.5
Component: Administration Keywords: has-patch
Focuses: Cc:


This ticket relates to #4151, #4709 and #5304

I've cleaned the file up to reduce duplicated code, Added PHPDoc comments, and included mentioned tickets within the cleanup.


  • function get_udims() duplicated wp_shrink_dimensions(), Switched it to use wp_shrink_dimensions() instead.
  • It appears that get_udims() is not used anywhere else in WP.
  • depreciated 3rd param($effect) to wp_create_thumbnail() as it isnt used within the function.
  • IMAGETYPE_XXX introduced with PHP 4.3.0 it appears, Added to compat.php.
  • The inline documentation may not be the best, And doesnt include Long descriptions for most of the functions.
  • Most functions should return a WP_Error object instead on error, For most compatibilit current patch follows previous error handling route.

Attachments (1)

5312.diff (11.1 KB) - added by DD32 16 years ago.
image.php cleanup

Download all attachments as: .zip

Change History (3)

16 years ago

image.php cleanup

#1 @westi
16 years ago

  • Owner changed from anonymous to westi
  • Status changed from new to assigned

#2 @westi
16 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [6309]) Refactor of wp-admin/includes/image.php. Fixes #5312, #4151, #4709, #5304 props DD32.

Note: See TracTickets for help on using tickets.