WordPress.org

Make WordPress Core

Opened 7 weeks ago

Last modified 7 weeks ago

#53355 reviewing defect (bug)

wp-signup.php with `new` in the query string results in a "site does not exist" message even if the site does exist

Reported by: henry.wright Owned by: SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: has-patch
Focuses: multisite Cc:

Description

Steps to reproduce:

  1. Visit example.com/wp-signup.php?new=sport where sport is the address of an existing site in your network. Note I'm using sport as an example. You should replace sport with the address of an existing blog in your network.

You will get the following message appear on the page:

The site you were looking for, https://sport.example.com/, does not exist, but you can create it now!

Attachments (4)

53355.diff (1.6 KB) - added by henry.wright 7 weeks ago.
53355.2.diff (1.8 KB) - added by henry.wright 7 weeks ago.
53355.3.diff (1.8 KB) - added by henry.wright 7 weeks ago.
53355.4.diff (1.9 KB) - added by henry.wright 7 weeks ago.

Download all attachments as: .zip

Change History (10)

#1 @henry.wright
7 weeks ago

To add, the network install I used to test allows both user and blog registrations

@henry.wright
7 weeks ago

#2 @henry.wright
7 weeks ago

  • Keywords has-patch added

53355.diff uses domain_exists() to check if a site name is already taken before outputting the message.

@henry.wright
7 weeks ago

#3 @henry.wright
7 weeks ago

53355.2.diff fixes the value of $domain which is passed to domain_exists() as the first param.

@henry.wright
7 weeks ago

#4 @henry.wright
7 weeks ago

53355.3.diff ensures the right parts of the extracted host name are used to build the domain value.

#5 @SergeyBiryukov
7 weeks ago

  • Milestone changed from Awaiting Review to 5.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Related: #53348

@henry.wright
7 weeks ago

#6 @henry.wright
7 weeks ago

53355.4.diff adds a separation character when building the domain value

Note: See TracTickets for help on using tickets.