WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#53369 closed defect (bug) (fixed)

Remove gutenberg plugin function in favor of WP's own function in `wp_migrate_old_typography_shape`

Reported by: walbo's profile walbo Owned by: desrosj's profile desrosj
Milestone: 5.8 Priority: normal
Severity: normal Version: 5.8
Component: Editor Keywords: has-patch commit
Focuses: Cc:

Description

In [51089] wp_migrate_old_typography_shape was added, but it used the Gutenberg plugin function gutenberg_experimental_set to set the array keys.

Should be updated to use WPs own _wp_array_set

Change History (8)

This ticket was mentioned in ​PR #1360 on ​WordPress/wordpress-develop by ​walbo.
4 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/53369

#2 @desrosj
4 years ago

  • Milestone changed from Awaiting Review to 5.8

This ticket was mentioned in ​Slack in #core by chaion07. ​View the logs.
4 years ago

#4 @JeffPaul
4 years ago

  • Keywords needs-testing added

#5 @chaion07
4 years ago

Hi @walbo! Thank you for reporting this. We reviewed the ticket during a [recent bug-scrub session in Core]​https://wordpress.slack.com/archives/C02RQBWTW/p1623702548380100. Based on the feedback from the team we feel the need for an owner to this issue. The PR/patch seems good with the only instance of gutenberg_experimental_set in core. We also think that the reporter is right. Drawing kind attention from @noisysocks on this one.

Props to @JeffPaul and @hellofromtonya

#6 @desrosj
4 years ago

  • Owner set to desrosj
  • Status changed from new to assigned

#7 @desrosj
4 years ago

  • Keywords commit added; needs-testing removed

This must be replaced in 5.8 because the gutenberg_experimental_set() function is not present in WordPress Core.

The PR looks good to me!

#8 @desrosj
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 51148:

Editor: Replace a Gutenberg specific function with the Core equivalent.

This replaces a stray instance of gutenberg_experimental_set() with the WordPress Core version of this function, _wp_array_set().

A stray gutenberg text domain is also removed from a __() call.

Props walbo, chaion07, JeffPaul.
Fixes #53369.

Note: See TracTickets for help on using tickets.