WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#53405 new enhancement

short circuit before current filters for get_edit_user_link

Reported by: shawfactor's profile shawfactor Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Users Keywords: needs-patch
Focuses: multisite, performance Cc:

Description

currently the function get_edit_user_link can be filtered BUT it is only after it has gone searching for an appropriate value.

This is problematic as on multisite this search may call get_edit_profile_url and then get_dashboard_url which in turn then runs get_blogs_of_user which pulls all the options for every site that the user is a member of into memory. This can be huge and completely unnecessary!!

There needs to be a way to short cicuit this function at the start before all this occurs.

Change History (3)

#1 @shawfactor
2 years ago

  • Summary changed from short circuit before current filters to short circuit before current filters for get_edit_user_link

This ticket was mentioned in ​Slack in #core by peterwilsoncc. ​View the logs.
2 years ago

#3 @chaion07
2 years ago

  • Component changed from General to Users
  • Focuses multisite performance added
  • Keywords needs-patch added

Hello @shawfactor! Thank you for reporting this. We recently reviewed this ticket during a ​recent triage session. Based on the feedback provided by the team, we have changed the component of the ticket to Users; added Multisite focus; and added needs-patch keyword. Cheers!

Props to @peterwilsoncc & @mikeschroder

Note: See TracTickets for help on using tickets.