WordPress.org

Make WordPress Core

Opened 6 weeks ago

Last modified 5 weeks ago

#53436 new enhancement

Add LottieFiles to list of sanctioned and trusted embed providers

Reported by: karamali Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.8
Component: Embeds Keywords: reporter-feedback
Focuses: Cc:

Description

Lottie is an open-source animation file format that’s tiny, high quality, interactive, and can be manipulated at runtime. The top 500 apps on the App store now use Lottie to engage users and enhance conversions.

As of recently, we at LottieFiles have complied with the oEmbed standard specification and WordPress supports embed of LottieFiles animations via auto-discovery.

I could create a PR to the WordPress core if that's the process to go about but would like to know the exact path to take to go about adding LottieFiles to this list. Initially, I created a PR to Gutenberg blocks to add it to their embeds variations list, however, was told that I should create a trac ticket and add LottieFiles to the list of trusted embed providers.

https://github.com/WordPress/wordpress-develop/blob/master/src/wp-includes/class-wp-oembed.php#L53-L104

https://wordpress.org/support/article/embeds/

video demo:
https://drive.google.com/file/d/1JrVhcthr5DkRBTDPzhVDC-ZVnylYgqIg/view?usp=sharing

Change History (3)

#1 @jorbin
6 weeks ago

Hi @karamali, Thanks for this ticket, and welcome to Trac!

We have a set of questions regarding whitelisting oEmbed providers which I'd ask you to answer: https://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers

#2 @swissspidy
6 weeks ago

WordPress supports embed of LottieFiles animations via auto-discovery.

It’s also part of the questionnaire, but can you perhaps elaborate why this doesn‘t suffice already?

#3 @desrosj
5 weeks ago

  • Keywords reporter-feedback added
Note: See TracTickets for help on using tickets.