WordPress.org

Make WordPress Core

Opened 3 months ago

Last modified 3 months ago

#53650 new defect (bug)

Incorrect quotation marks in many strings

Reported by: tobifjellner Owned by:
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.8
Component: I18N Keywords: needs-patch
Focuses: coding-standards Cc:

Description

Among the strings that just became available for translation, several strings use incorrect quotation marks. As I started looking for what specific strings, I found strings that got added earlier, too. In most cases, these strings need to be corrected upstream, in the block editor, etc. So I'm dumping this here as a start. Next step would probably be to split these on the various relevant sub projects.

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/block-library.js?marks=29155#L29155
WordPress contains different types of content and they are divided into collections called "Post Types". By default there are a few different ones such as blog posts and pages, but plugins could add more.

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/block-library.js?marks=29183#L29183
Blog posts can be "stickied", a feature that places them at the top of the front page of posts, keeping it there until new sticky posts are published.

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/block-library.js?marks=31216#L31216
Add "read more" link text

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/widgets.js?marks=766#L766
The "%s" block was affected by errors and may not function properly. Check the developer tools for more details.

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/edit-post.js?marks=15242#L15242
Give the template a title that indicates its purpose, e.g. "Full Width".

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/edit-post.js?marks=16883#L16883
Describe the purpose of the template, e.g. "Full Width". Custom templates can be applied to any post or page.

https://build.trac.wordpress.org/browser/trunk/wp-includes/blocks.php?marks=1031#L1031
Block "%1$s" is declaring %2$s support in %3$s file under %4$s. %2$s support is now declared under %5$s.

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/block-library.js?marks=31215#L31215
"Read more" link text

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/block-editor.js?marks=22663#L22663
Block pattern "%s" inserted.

https://build.trac.wordpress.org/browser/trunk/wp-includes/theme.php?marks=3163#L3163
The "%s" must be a callable function.

https://build.trac.wordpress.org/browser/trunk/wp-includes/option.php?marks=100#L100 (+ 2 more occurrences in same file)
The "%1$s" option key has been renamed to "%2$s".

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/block-editor.js?marks=26878#L26878
Copied "%s" to clipboard.

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/block-editor.js?marks=26879#L26879
Moved "%s" to clipboard.

https://build.trac.wordpress.org/browser/trunk/wp-includes/class-wp-block-pattern-categories-registry.php?marks=70#L70
Block pattern category "%s" not found.

https://build.trac.wordpress.org/browser/trunk/wp-includes/class-wp-block-patterns-registry.php?marks=91#L91
Pattern "%s" not found.

https://build.trac.wordpress.org/browser/trunk/wp-includes/blocks.php?marks=91#L91
The asset file for the "%1$s" defined in "%2$s" block definition is missing.

https://build.trac.wordpress.org/browser/trunk/wp-includes/rest-api.php?marks=1595#L1595
The "type" schema keyword for %1$s can only contain the built-in types: %2$l.

https://build.trac.wordpress.org/browser/trunk/wp-includes/rest-api.php?marks=2076#L2076 (+1 more occurrence in same file)
The "type" schema keyword for %s is required.

https://build.trac.wordpress.org/browser/trunk/wp-includes/rest-api.php?marks=2098#L2098 (+1 more occurrence in same file)
The "type" schema keyword for %1$s can only be one of the built-in types: %2$l.

https://build.trac.wordpress.org/browser/trunk/wp-includes/theme.php?marks=3145#L3145
When registering an "array" feature, the feature's schema must include the "items" keyword.

https://build.trac.wordpress.org/browser/trunk/wp-includes/theme.php?marks=3152#L3152
When registering an "object" feature, the feature's schema must include the "properties" keyword.

https://build.trac.wordpress.org/browser/trunk/wp-includes/theme.php?marks=3123#L3123
The feature "type" is not valid JSON Schema type.

https://build.trac.wordpress.org/browser/trunk/wp-includes/theme.php?marks=3130#L3130
When registering a "variadic" theme feature, the "type" must be an "array".

https://build.trac.wordpress.org/browser/trunk/wp-includes/theme.php?marks=3138#L3138
When registering an "array" or "object" feature to show in the REST API, the feature's schema must also be defined.

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/block-library.js?marks=11494#L11494

A "block" is the abstract term used
to describe units of markup that
when composed together, form the
content or layout of a page.
registerBlockType( name, settings );

https://build.trac.wordpress.org/browser/trunk/wp-includes/capabilities.php?marks=252#L252
The post status %1$s is not registered, so it may not be reliable to check the capability "%2$s" against a post with that status.

https://build.trac.wordpress.org/browser/trunk/wp-includes/option.php?marks=2305#L2305
When registering an "array" setting to show in the REST API, you must specify the schema for each array item in "show_in_rest.schema.items".

https://build.trac.wordpress.org/browser/trunk/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php?marks=2502#L2502
The "%1$s" taxonomy "%2$s" property (%3$s) conflicts with an existing property on the REST API Posts Controller. Specify a custom "rest_base" when registering the taxonomy to avoid this error.

https://build.trac.wordpress.org/browser/trunk/wp-includes/class-wp-block-styles-registry.php?marks=85#L85
Block "%1$s" does not contain a style named "%2$s".

https://build.trac.wordpress.org/browser/trunk/wp-includes/meta.php?marks=1339#L1339
When registering an "array" meta type to show in the REST API, you must specify the schema for each array item in "show_in_rest.schema.items".

https://build.trac.wordpress.org/browser/trunk/wp-includes/blocks/quote/block.json?marks=0#L0
Give quoted text visual emphasis. "In quoting others, we cite ourselves." — Julio Cortázar

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/block-library.js?marks=19348#L19348
Your site doesn’t include support for the "%s" block. You can leave this block intact, convert its content to a Custom HTML block, or remove it entirely.

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/block-library.js?marks=19357#L19357
Your site doesn’t include support for the "%s" block. You can leave this block intact or remove it entirely.

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/editor.js?marks=8530#L8530
Apply the "%1$s" format.

https://build.trac.wordpress.org/browser/trunk/wp-includes/class-wp-block-type-registry.php?marks=86#L86
Block type "%s" is already registered.

https://build.trac.wordpress.org/browser/trunk/wp-includes/class-wp-block-type-registry.php?marks=119#L119
Block type "%s" is not registered.

https://build.trac.wordpress.org/browser/trunk/wp-includes/user.php?marks=4210#L4210
Confirm the "%s" action

https://build.trac.wordpress.org/browser/trunk/wp-includes/script-loader.php?marks=1201#L1201
Schedule your customization changes to publish ("go live") at a future date.

https://build.trac.wordpress.org/browser/trunk/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php?marks=1296#L1296
Passwords cannot contain the "%s" character.

https://build.trac.wordpress.org/browser/trunk/wp-includes/option.php?marks=2318#L2318 (+ 3 more places in same file)
https://build.trac.wordpress.org/browser/trunk/wp-admin/includes/template.php?marks=1569#L1569 (+ 3 more places in same file)
The "%s" options group has been removed. Use another settings group.

https://build.t
rac.wordpress.org/browser/trunk/wp-includes/capabilities.php?marks=95#L95 (+ 3 more places in same file)
The post type %1$s is not registered, so it may not be reliable to check the capability "%2$s" against a post of that type.

https://build.trac.wordpress.org/browser/trunk/wp-includes/class-wp-theme.php?marks=241#L241
The theme directory "%s" does not exist.

https://build.trac.wordpress.org/browser/trunk/wp-includes/class-wp-theme.php?marks=384#L384 (+ 1 more place in same file)
The "%s" theme is not a valid parent theme.

https://build.trac.wordpress.org/browser/trunk/wp-includes/pluggable.php?marks=1664#L1664
New comment on your post "%s"

https://build.trac.wordpress.org/browser/trunk/wp-includes/pluggable.php?marks=1636#L1636
New trackback on your post "%s"

https://build.trac.wordpress.org/browser/trunk/wp-includes/pluggable.php?marks=1650#L1650
New pingback on your post "%s"

https://build.trac.wordpress.org/browser/trunk/wp-includes/pluggable.php?marks=1825#L1825
A new trackback on the post "%s" is waiting for your approval

https://build.trac.wordpress.org/browser/trunk/wp-includes/pluggable.php?marks=1836#L1836
A new pingback on the post "%s" is waiting for your approval

https://build.trac.wordpress.org/browser/trunk/wp-includes/pluggable.php?marks=1847#L1847
A new comment on the post "%s" is waiting for your approval

https://build.trac.wordpress.org/browser/trunk/wp-includes/pluggable.php?marks=1681#L1681
[%1$s] Comment: "%2$s"

https://build.trac.wordpress.org/browser/trunk/wp-includes/pluggable.php?marks=1645#L1645
[%1$s] Trackback: "%2$s"

https://build.trac.wordpress.org/browser/trunk/wp-includes/pluggable.php?marks=1659#L1659
[%1$s] Pingback: "%2$s"

https://build.trac.wordpress.org/browser/trunk/wp-includes/pluggable.php?marks=1892#L1892
[%1$s] Please moderate: "%2$s"

https://build.trac.wordpress.org/browser/trunk/wp-includes/class-wp-theme.php?marks=357#L357
The parent theme is missing. Please install the "%s" parent theme.

https://build.trac.wordpress.org/browser/trunk/wp-includes/js/dist/block-editor.js?marks=33470#L33470
Search results for "%s"

Change History (3)

#1 @desrosj
3 months ago

  • Component changed from General to I18N
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.8.1

#2 @SergeyBiryukov
3 months ago

I think some of these strings are not new in 5.8 and should preferably be fixed in 5.9 rather than in 5.8.1, to minimize the number of non-urgent string changes in a minor release.

IIRC, the consensus previously was to use “curly quotes” in user-facing strings for better typography. Developer notices and email subjects can probably continue using regular double quotes.

#3 @desrosj
3 months ago

  • Milestone changed from 5.8.1 to 5.9

That makes sense to me!

Note: See TracTickets for help on using tickets.